LDG-510 + LDG-528: Implement Sign Transfer & Sign Transfer with memo #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add sign_simple_transfer method to BoilerplateCommandSender - Add two test cases for simple transfer signing: - Legacy path - New path - Format tests - Generate golden snapshots
GuilaneDen
previously approved these changes
Dec 5, 2024
- Implement sign_simple_transfer_with_memo method in BoilerplateCommandSender - Add test case for signing a simple transfer with memo using legacy path - Update test assertions to verify signature correctness
keiff3r
changed the title
keiff3r
requested review from
GuilaneDen and
a team
and removed request for
GuilaneDen
n4l5u0r
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.