Feat/LDG-530--nano-app-implement-signtransferwithscheduleand #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test_sign_tx_transfer_with_schedule_and_memo_legacy_path to verify signing functionality for transactions that combine scheduled transfers with memos. The test includes: - New P1 enum values for memo scheduled transfers - Refactored variable name from memo_chunk to memo_chunks for clarity - Added new test case that: - Sends header with address - Processes memo in chunks - Handles multiple scheduled payment pairs - Verifies final signature Related changes: - Added P1_MEMO_SCHEDULED_TRANSFER (0x03) - Added P1_INITIAL_SCHEDULED_TRANSFER_WITH_MEMO (0x02)
n4l5u0r
previously approved these changes
Dec 9, 2024
|
@keiff3r tu as des conflits à résoudre |
…p-implement-signtransferwithscheduleand
n4l5u0r
approved these changes
Dec 9, 2024
n4l5u0r
deleted the
feat/LDG-530--nano-app-implement-signtransferwithscheduleand
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test_sign_tx_transfer_with_schedule_and_memo_legacy_path to verify signing
functionality for transactions that combine scheduled transfers with memos.
The test includes:
Related changes: