Feat/ldg 516 nano app implement exportprivatekey method #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for new key derivation paths by introducing `isNewPath` flag in `exportPrivateKeyContext_t`. - Updated `exportPrivateKeySeed` and `exportPrivateKeyBls` functions to handle both legacy and new paths. - Modified `handleExportPrivateKey` to parse `dataBuffer` for new path information and adjust key derivation path accordingly. - Extended `display` buffer size in `exportPrivateKeyContext_t` to accommodate new path display information. - Updated `derivation_path_keys_t` enum to include new path keys `NEW_ID_CRED_SEC` and `NEW_PRF_KEY`.
Add support for exporting private keys with different modes: - Add new P1 parameters for export types (standard, recovery, prfkey_and_idcredsec) - Add P2 parameter for BLS key export - Implement export_private_key method with support for: - Identity index based export - IDP index based export - Different export types via P1 parameter The implementation includes: - Type safety using Literal types for export modes - Proper data serialization for both identity and IDP index modes - Context manager pattern for async response handling
- Adjust display string formatting to handle IDP and ID numbers correctly - Fix offset calculation by using bin2dec return value - Remove null terminator to ensure proper string concatenation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
n4l5u0r
previously approved these changes
Dec 10, 2024
keiff3r
dismissed
n4l5u0r’s stale review
The merge-base changed after approval.
n4l5u0r
previously approved these changes
Dec 10, 2024
keiff3r
dismissed
n4l5u0r’s stale review
The merge-base changed after approval.
Z4karia
previously approved these changes
Dec 10, 2024
…p-implement-exportprivatekey-method
n4l5u0r
previously approved these changes
Dec 10, 2024
n4l5u0r
approved these changes
Dec 10, 2024
n4l5u0r
deleted the
feat/LDG-516--nano-app-implement-exportprivatekey-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.