Feat/LDG-535--nano-app-implement-deploy-method #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new instruction INS_DEPLOY_MODULE (0x06) to handle module deployment - Create deployModule.c/.h files with handler implementation - Add UI flow for displaying module version and transaction details - Add new error code ERROR_INVALID_SOURCE_LENGTH - Implement Python test client for deployModule instruction - Add test case for module deployment flow - Update handler.c to support new instruction The implementation allows users to deploy modules by processing the version and source data in chunks, with appropriate UI confirmation steps.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+22
to
+25
| // typedef struct { | ||
| // uint8_t version[32]; | ||
| // uint8_t sourceLength[32]; | ||
| // } deployModuleBlob_t; |
Check notice
Code scanning / CodeQL
Commented-out code Note
- Add @contextmanager decorator to deploy_module method - Rename test_credential_deployment to test_deploy_module - Update test to use deploy_module instead of credential_deployment - Remove unused snapshot images Aligns test naming and implementation with actual functionality being tested.
- Remove @contextmanager decorator from credential_deployment_part_1 method - Fix test flow for credential deployment process Removes incorrectly added context manager decorator that was not needed for this specific credential deployment method.
n4l5u0r
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation allows users to deploy modules by processing the version
and source data in chunks, with appropriate UI confirmation steps.