Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/LDG-539--nano-app-implement-update-method #42

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

keiff3r
Copy link

@keiff3r keiff3r commented Dec 11, 2024

  • Add new instruction INS_UPDATE_CONTRACT (0x08) for contract updates
  • Add update contract UI flow with amount/index/subindex display
  • Update handler.c to support new instruction
  • Add P1 constants for update contract flow stages
  • Add Python client support for update contract instruction
  • Add test cases for both small and large parameter sets
  • Update globals.h to include updateContract context

Allows users to update existing contracts by providing new parameters,
following the same chunked data approach as init contract but with
additional index/subindex display in the UI flow.

- Add new instruction INS_UPDATE_CONTRACT (0x08) for contract updates
- Add update contract UI flow with amount/index/subindex display
- Update handler.c to support new instruction
- Add P1 constants for update contract flow stages
- Add Python client support for update contract instruction
- Add test cases for both small and large parameter sets
- Update globals.h to include updateContract context

Allows users to update existing contracts by providing new parameters,
following the same chunked data approach as init contract but with
additional index/subindex display in the UI flow.
Comment on lines +37 to +40
// typedef struct {
// uint8_t version[32];
// uint8_t sourceLength[32];
// } deployModuleBlob_t;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@keiff3r keiff3r marked this pull request as ready for review December 11, 2024 16:52
@keiff3r keiff3r requested a review from a team December 11, 2024 16:52
@n4l5u0r n4l5u0r merged commit 476bb73 into main Dec 11, 2024
29 of 30 checks passed
@n4l5u0r n4l5u0r deleted the feat/LDG-539--nano-app-implement-update-method branch December 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants