Feat/LDG-615--nano-app-implement-deploy-stax-and-flex-display #44
Conversation
- Add uiDeployModuleDisplay function for Stax/Flex support - Create pairs array for tag-value display - Add review_choice_sign callback for transaction signing - Display sender and version information in UI - Use nbgl_useCaseReview for consistent UI pattern - Generate golden snapshots Implements the UI flow for module deployment on newer Ledger devices (Stax/Flex) using the NBGL library, displaying sender and version information with proper signing confirmation.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // validate_transaction(confirm); | ||
| if (confirm) { | ||
| buildAndSignTransactionHash(); | ||
| // nbgl_useCaseReviewStatus(STATUS_TYPE_TRANSACTION_SIGNED, ui_menu_main); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // nbgl_useCaseReviewStatus(STATUS_TYPE_TRANSACTION_SIGNED, ui_menu_main); | ||
| } else { | ||
| sendUserRejection(); | ||
| // nbgl_useCaseReviewStatus(STATUS_TYPE_TRANSACTION_REJECTED, ui_menu_main); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // // Add sender address | ||
| // pairs[pairIndex].item = "Sender"; | ||
| // pairs[pairIndex].value = (char *) global_account_sender.sender; | ||
| // pairIndex++; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // // Add capital amount if present | ||
| // if (ctx->hasCapital) { | ||
| // if (ctx->stopDelegation) { | ||
| // pairs[pairIndex].item = "Action"; | ||
| // pairs[pairIndex].value = "Stop delegation"; | ||
| // } else { | ||
| // pairs[pairIndex].item = "Amount to delegate"; | ||
| // pairs[pairIndex].value = (char *) ctx->displayCapital; | ||
| // } | ||
| // pairIndex++; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // // Add restake earnings if present | ||
| // if (ctx->hasRestakeEarnings) { | ||
| // pairs[pairIndex].item = "Restake earnings"; | ||
| // pairs[pairIndex].value = (char *) ctx->displayRestake; | ||
| // pairIndex++; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // // Add delegation target if present | ||
| // if (ctx->hasDelegationTarget) { | ||
| // pairs[pairIndex].item = "Delegation target"; | ||
| // pairs[pairIndex].value = (char *) ctx->displayDelegationTarget; | ||
| // pairIndex++; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // // Create the page content | ||
| // nbgl_pageContent_t content; | ||
| // content.type = TAG_VALUE_LIST; | ||
| // content.title = "Review Transaction"; | ||
| // content.isTouchableTitle = true; | ||
| // content.topRightIcon = NULL; | ||
| // content.tagValueList.nbPairs = pairIndex; | ||
| // content.tagValueList.pairs = pairs; | ||
| // content.tagValueList.smallCaseForValue = false; | ||
| // content.tagValueList.nbMaxLinesForValue = 0; |
Check notice
Code scanning / CodeQL
Commented-out code Note
n4l5u0r
deleted the
feat/LDG-615--nano-app-implement-deploy-stax-and-flex-display
branch
Implements the UI flow for module deployment on newer Ledger devices
(Stax/Flex) using the NBGL library, displaying sender and version
information with proper signing confirmation.