Feat/ldg 506 nano app implement verifyaddress method #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for verifying Concordium addresses on the device. This includes: - New handler for VERIFY_ADDRESS command - BLS key generation and credential ID computation - Base58 address encoding utilities - UI flows for address verification on both BAGL and NBGL displays - Constants for BIP32 paths and address formats - Helper functions for key derivation and address conversion The implementation follows the legacy address format and allows users to verify addresses by displaying the identity index, credential counter, and computed address on device for confirmation.
* refactor(crypto): change private key type from raw bytes to cx_ecfp_private_key_t * fix(ui): replace format_hex with direct uint32_t formatting for address components * fix(ui): use memcpy instead of format_hex for address display The changes improve the handling of private keys by using the proper BOLOS crypto type and fix the address display by using appropriate formatting methods for both the address components and the final address string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 3 3
Lines 53 53
=======================================
Hits 44 44
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GuilaneDen
reviewed
Nov 26, 2024
GuilaneDen
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.