Feat/LDG-607--nano-app-implement-signtransferwithscheduleandme #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiff3r
commented
Dec 12, 2024
keiff3r
commented
- Add NBGL test cases for sign_tx_transfer_with_schedule_and_memo
- Update test navigation logic to handle both Nano and NBGL devices
- Adjust screenshot counter based on device type
- Update navigation instructions for final review confirmation
- Generate golden snapshots
- Add NBGL UI implementation for sign_tx_transfer_with_schedule - Add NBGL UI implementation for initial scheduled transfer display - Update test_sign_cmd.py to handle NBGL navigation for scheduled transfers - Add keep_going_with_transaction wrapper to fix build warnings Note: Test for transfer_with_schedule_and_memo still needs to be implemented BREAKING CHANGE: Added support for Flex and Stax devices in ledger_app.toml
- Add NBGL test cases for sign_tx_transfer_with_schedule_and_memo - Update test navigation logic to handle both Nano and NBGL devices - Adjust screenshot counter based on device type - Update navigation instructions for final review confirmation - Generate golden snapshots
keiff3r
force-pushed
the
feat/LDG-607--nano-app-implement-signtransferwithscheduleandme
branch
from
e4dd420 to
5379f0f
Compare
n4l5u0r
approved these changes
Dec 13, 2024
n4l5u0r
deleted the
feat/LDG-607--nano-app-implement-signtransferwithscheduleandme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.