feat(error-handling): improve error messages granularity #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add specific status words for different error scenarios in key derivation and address verification - Split generic SW_VERIFY_ADDRESS_FAIL into more specific error codes: - SW_BLS_KEY_GEN_FAIL - SW_KEY_INIT_FAIL - SW_CREDENTIAL_ID_GEN_FAIL - SW_ADDRESS_ENCODING_FAIL - SW_DERIVATION_PATH_FAIL - Enhance error handling in get_bls_private_key and get_private_key_from_path - Update function documentation with detailed error codes - Remove redundant clang-format option This change improves debugging capabilities by providing more granular error feedback.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 3 3
Lines 53 53
=======================================
Hits 44 44
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changes the CURVE_APP_LOAD_PARAMS in the Makefile to use ed25519 instead of secp256k1 for cryptographic operations.
GuilaneDen
approved these changes
Nov 27, 2024
keiff3r
deleted the
feat/LDG-506--nano-app-implement-verifyaddress-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves debugging capabilities by providing more granular error feedback.