Feat/ldg 510 nano app implement signtransfer method #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into test/LDG-505--nano-app-implement-verifyaddress-test
…p-implement-verifyaddress-test
Add support for parsing and displaying simple transfer transactions. Signing implementation will follow in a subsequent commit. Key changes: - Replace generic transaction handling with specific simple transfer support - Update transaction parsing to handle simple transfer payload format - Add new UI flow to display simple transfer details including sender/recipient - Switch from keccak to SHA256 for transaction hashing - Update address handling to use 32-byte Concordium addresses - Add base58 address encoding for better readability - Remove unused transaction serialization code - Update command enum to use SIGN_SIMPLE_TRANSFER Technical details: - Added transaction type enum and union to support multiple tx types - Updated transaction context to store raw transaction type - Added address format conversion utilities - Simplified transaction parsing by removing generic structure
- Rename SIGN_TX instruction to SIGN_SIMPLE_TRANSFER for clarity - Update sign_tx method to accept transaction type instruction - Fix test_sign_tx_simple_transfer with correct transaction hex data - Update test_error_cmd to use new instruction name - Modify command sender to support different transaction signing types This change enables proper testing of simple transfer signing and generates corresponding golden snapshots.
- Change signature algorithm from ECDSA (secp256k1) to EdDSA (Ed25519) - Reduce MAX_DER_SIG_LEN from 72 to 64 bytes for Ed25519 signatures - Remove 'v' parameter as it's specific to ECDSA - Simplify signature response format to raw bytes - Update crypto_sign_message to use cx_eddsa_sign_no_throw - Adjust test assertions for new signature format This change implements the correct signature scheme for the protocol and fixes the corresponding test cases.
…p-implement-signtransfer-method
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
n4l5u0r
approved these changes
Nov 30, 2024
keiff3r
deleted the
feat/LDG-510--nano-app-implement-signtransfer-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.