-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document the support for constraints #300
Conversation
prjemian
commented
Nov 10, 2023
•
edited
Loading
edited
- close Constraints stack needs documentation #290
- close BUG: restore(configuration) should push constraints to stack #301
During testing (and confirming user reports), the Marking this PR as draft for now. |
The diffractometer (engine)
|
This comment describes the meaning of
Here are the places in libhkl source where (base) prjemian@arf:~/.../picca/hkl$ git grep fit_get
gui/hkl-gui.c: fit = hkl_parameter_fit_get(p); \
gui/hkl-gui.c: gboolean fit = hkl_parameter_fit_get(p); \
hkl.h:HKLAPI int hkl_parameter_fit_get(const HklParameter *self) HKL_ARG_NONNULL(1);
hkl/hkl-parameter.c: * hkl_parameter_fit_get:
hkl/hkl-parameter.c:int hkl_parameter_fit_get(const HklParameter *self)
tests/hkl-axis-t.c: ok(TRUE == hkl_parameter_fit_get(axis), __func__);
tests/hkl-axis-t.c: ok(TRUE == hkl_parameter_fit_get(axis), __func__);
tests/hkl-axis-t.c: ok(TRUE == hkl_parameter_fit_get(copy), __func__);
tests/hkl-axis-t.c: ok(TRUE == hkl_parameter_fit_get(copy), __func__); Not apparent it is used anywhere in the computation of |
To avoid making a breaking change, by dropping this parameter altogether, consider these actions now:
|
Confirmed with Fred Picca that the
|
@mrakitin @rodolakis @strempfer @padraic-shafer -- This is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated documentation is helpful and clearer. Thanks for that!
(Btw, I skipped the SPEC docs in this review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I have a suggestion about the .ipynb files rendering, which can be addressed in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notebooks like this one are already rendered, which makes it hard to review as there are huge image diffs there. I think we can use https://github.com/kynan/nbstripout and auto-render the notebooks during the sphinx docs building process using https://nbsphinx.readthedocs.io/en/0.9.3/.