Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE - Light/Dark mode cannot detect user's settings #1026

Closed
marcelluscaio opened this issue Oct 22, 2024 · 5 comments
Closed

FE - Light/Dark mode cannot detect user's settings #1026

marcelluscaio opened this issue Oct 22, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@marcelluscaio
Copy link
Contributor

Describe the bug
Light/Dark mode cannot detect user's settings

To Reproduce
Change system and browser settings to Dark, and access the project. You will see that the it defaults to light.

Expected behavior
Page should detect user's settings for light/dark mode.

Additional context
I believe we could follow a native approach using prefers-color-scheme's media query

@gorkem-bwl
Copy link
Contributor

Yep, let's do this one. Setting the label as "good-first-issue" as it's relatively an easy feature for contributors.

@gorkem-bwl gorkem-bwl added the good first issue Good for newcomers label Oct 22, 2024
@aarya-16
Copy link
Contributor

@marcelluscaio I've looked at it and seen what needs to be done. Can I work on this ?

@marcelluscaio
Copy link
Contributor Author

Yes, @aarya-16 ! Thank you for your interest

@aarya-16
Copy link
Contributor

@marcelluscaio I have made PR #1072 addressing this issue.

@marcelluscaio
Copy link
Contributor Author

Thanks for your contribution, @aarya-16 . I will check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants