Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Password Field BG color #1275

Closed
ajhollid opened this issue Dec 4, 2024 · 11 comments
Closed

Current Password Field BG color #1275

ajhollid opened this issue Dec 4, 2024 · 11 comments
Assignees
Labels
design Design related
Milestone

Comments

@ajhollid
Copy link
Collaborator

ajhollid commented Dec 4, 2024

While using dark theme, the "Current Password" field on the Password page has a white background on initial visit:

image

Steps to reproduce:

  1. Go to Monitor page or any other top level page
  2. Expand the account menu item and navigate to "Password"
@ajhollid ajhollid added this to the 2.0 milestone Dec 4, 2024
@saksham-malhotra-27
Copy link
Contributor

Hey ! I can do this one if you say

@gorkem-bwl
Copy link
Contributor

Hey ! I can do this one if you say

Sure! Go ahead please. Make sure you deploy the app and send a screenshot showing it is fixed.

@saksham-malhotra-27
Copy link
Contributor

Alright !

@saksham-malhotra-27
Copy link
Contributor

saksham-malhotra-27 commented Dec 4, 2024

Hi ,
I tried reproducing the issue with the "Current Password" field on the Password page when using the dark theme. However, when I visited the page, the background color appeared correct, matching the dark theme, rather than showing a white background as described.

Could you kindly confirm the following to help me understand the issue better?

  1. Browser & Version: Could you let me know which browser and version you were using when you encountered the problem?
  2. Steps to Reproduce: Did the issue occur immediately after visiting the page, or was there any delay in loading the theme?
  3. Clearing Cache: Have you tried clearing the browser cache or testing in an incognito window to ensure the issue persists?

This will help me troubleshoot more effectively.

Additionally, I've noticed that if we use Google-suggested passwords or passwords saved in Google, we encounter the white background in the text field. I've attached two screenshots for reference:

  1. My view, where the background appears correct:
    image

  2. White background issue, which occurs when using Google-suggested passwords:
    image

  3. Aftermath of using a strong password via Google:
    image

If the bug is being reproduced in this way, please let me know, and I can investigate further.

Thank you for your help!

@saksham-malhotra-27
Copy link
Contributor

If the issue is due to Google’s remembered passwords, it applies here as well, as shown in the screenshot:
image

This seems to be related to Chrome's autofill feature, which remembers certain fields like email or password. It’s possible that whenever these remembered fields are used, this problem arises.

This appears to be related to Chrome's autofill feature, which remembers fields like email or password. Could this behavior be linked to the issue, or can it be considered negligible since the white background doesn’t appear in other scenarios?

@saksham-malhotra-27
Copy link
Contributor

Hey!
I did some research and came across a similar issue that others have faced. Here's an example I found:
Elastic EUI Issue

I made a few modifications to the code, and it’s working now! 🎉
Check it out:
image
image
image
image

Let me know what you think!

@marcelluscaio
Copy link
Contributor

Nice @saksham-malhotra-27 ! Did you open a PR for that?

@gorkem-bwl
Copy link
Contributor

Looks great! It's an issue with most of the apps I saw and never thought it could be fixed. :)

saksham-malhotra-27 added a commit to saksham-malhotra-27/checkmate that referenced this issue Dec 5, 2024
@saksham-malhotra-27
Copy link
Contributor

Hey! Just about to open a PR.
Let me know if everything looks good.

saksham-malhotra-27 added a commit to saksham-malhotra-27/checkmate that referenced this issue Dec 5, 2024
@gorkem-bwl gorkem-bwl modified the milestones: 2.0, 2.1 Dec 5, 2024
@saksham-malhotra-27
Copy link
Contributor

Hey! It would be great if you could review my PR and share any suggestions for improvement.

@saksham-malhotra-27
Copy link
Contributor

Hey @gorkem-bwl @marcelluscaio ! I submitted a PR related to this a couple of days ago. Could you please review it when you get a chance?

ajhollid added a commit that referenced this issue Dec 10, 2024
…rrent_password_BG_color

feat #1275: design corrected  : Current Password Field BG color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related
Projects
None yet
Development

No branches or pull requests

4 participants