Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE - Hardware Monitoring Integration #985

Closed
4 tasks done
ajhollid opened this issue Oct 18, 2024 · 8 comments
Closed
4 tasks done

BE - Hardware Monitoring Integration #985

ajhollid opened this issue Oct 18, 2024 · 8 comments
Assignees
Milestone

Comments

@ajhollid
Copy link
Collaborator

ajhollid commented Oct 18, 2024

The BE needs to be prepared to integrate with the hardware monitoring agent being developed by @mertssmnoglu

  • Design and implement database models
  • Design and Implement DB methods
  • Update NetworkService to handle Hardware monitor types
@ajhollid ajhollid self-assigned this Oct 18, 2024
@ajhollid ajhollid added this to the 2.0 milestone Oct 18, 2024
@mertssmnoglu
Copy link
Contributor

Work in Progress on Hardware Monitoring Agent

@gorkem-bwl
Copy link
Contributor

Looks good. Can we also send the distro_name, OS and kernel_version alongside with those properties you have in your repo @mertssmnoglu ?

@mertssmnoglu
Copy link
Contributor

Looks good. Can we also send the distro_name, OS and kernel_version alongside with those properties you have in your repo @mertssmnoglu ?

Yes we can do it. Sample output will be as follows

{
...

"host":{
  "os": "GNU/Linux",
  "distro_name": "Ubuntu"
  "kernel_version": "6.x.x LTS"
}

}

I will share all the properties with you in json format as soon as possible.

@mertssmnoglu
Copy link
Contributor

I'm updating the Agent's API Responses you can check the repo here

Memory metrics are done for Linux, but I want to ask you about memory usage percentage response. Which response is more usable/effective for both frontend and backend?

"memory": {
  ...
  "usage_percent": 0.417053
}
"memory": {
  ...
  "usage_percent": 41.7053
}

@gorkem-bwl
Copy link
Contributor

While the backend can take care of both, for the sake of human readability, I would say the second one is more appropriate. You can even leave a single digit after the dot.

@ajhollid
Copy link
Collaborator Author

While the backend can take care of both, for the sake of human readability, I would say the second one is more appropriate. You can even leave a single digit after the dot.

@mertssmnoglu @gorkem-bwl we use decimal format elsewhere in the BE (0.4325 instead of 43.25) so if it's no big deal it would be nice to keep that consistently on the BE.

FE we will definitely display a user friendly format.

@gorkem-bwl
Copy link
Contributor

While the backend can take care of both, for the sake of human readability, I would say the second one is more appropriate. You can even leave a single digit after the dot.

@mertssmnoglu @gorkem-bwl we use decimal format elsewhere in the BE (0.4325 instead of 43.25) so if it's no big deal it would be nice to keep that consistently on the BE.

FE we will definitely display a user friendly format.

Lol I jumped in too soon :-D

ajhollid added a commit that referenced this issue Oct 22, 2024
…g-model

feat/be/hardware-checks-model references #985
ajhollid added a commit that referenced this issue Oct 22, 2024
…nitor

feat/be/create-hardware-monitor, references #985
@ajhollid
Copy link
Collaborator Author

BE implemenation is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants