-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to logo #1060
Add link to logo #1060
Conversation
Testing is always necessary :) We require contributors to be able to deploy the app and test themselves. Leaving it out to one of core maintainers to check this and decide what to do. |
WalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
Client/src/Components/Sidebar/index.jsx (1)
184-185
: Yo! Consider adding some visual feedback for that sweet interaction!The current implementation only changes the cursor. Adding hover and active states would improve user experience.
Here's a suggestion to make it pop:
- sx={{ cursor: "pointer" }} + sx={{ + cursor: "pointer", + transition: 'transform 0.2s ease-in-out', + '&:hover': { + transform: 'scale(1.02)', + }, + '&:active': { + transform: 'scale(0.98)', + } + }}
I'll keep that in mind for next time. Again, I'm sorry for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for implementing that 👍
@@ -181,6 +181,8 @@ function Sidebar() { | |||
direction="row" | |||
alignItems="center" | |||
gap={theme.spacing(4)} | |||
onClick={() => window.open("https://github.com/bluewave-labs/bluewave-uptime", "_blank", "noreferrer")} | |||
sx={{ cursor: "pointer" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK on my end 👍
This PR adds a link to the logo
Let me know if I need to make further changes.
I apologize for taking so long. Still can't figure out the installation (stuck on the .env variables), I think it's my laptop.
If testing is necessary, could someone else do it?