Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to logo #1060

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add link to logo #1060

merged 1 commit into from
Oct 25, 2024

Conversation

khd33j
Copy link

@khd33j khd33j commented Oct 24, 2024

  • This PR adds a link to the logo

    • Set an onClick() listener to the icon (BU) and 'BlueWave Uptime'
    • The link opens up in a new tab as specified here
    • The cursor switches to a pointer when hovering on the logo

Let me know if I need to make further changes.

I apologize for taking so long. Still can't figure out the installation (stuck on the .env variables), I think it's my laptop.
If testing is necessary, could someone else do it?

@khd33j khd33j marked this pull request as ready for review October 24, 2024 18:00
@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Oct 24, 2024

I apologize for taking so long. Still can't figure out the installation (stuck on the .env variables), I think it's my laptop. If testing is necessary, could someone else do it?

Testing is always necessary :) We require contributors to be able to deploy the app and test themselves. Leaving it out to one of core maintainers to check this and decide what to do.

Copy link

coderabbitai bot commented Oct 24, 2024

Walkthrough

The pull request introduces modifications to the Sidebar component located in Client/src/Components/Sidebar/index.jsx. A new click handler has been added to the sidebar header, enabling users to open the BlueWave Uptime GitHub repository in a new tab. This is implemented through an onClick event on the Stack component, which now includes a cursor style to indicate clickability. The sidebar's existing structure and menu items remain unchanged, ensuring continuity in functionality while enhancing user interaction.

Changes

File Change Summary
Client/src/Components/Sidebar/index.jsx Added click handler to sidebar header to open GitHub repository in a new tab; updated cursor style.

Possibly related PRs

  • revamp side-menu #956: The changes in this PR also modify the Sidebar component in the same file, specifically altering the navigation logic and structure, which may interact with the new click handler added in the main PR.

Suggested reviewers

  • ajhollid

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)
Client/src/Components/Sidebar/index.jsx (1)

184-185: Yo! Consider adding some visual feedback for that sweet interaction!

The current implementation only changes the cursor. Adding hover and active states would improve user experience.

Here's a suggestion to make it pop:

-        sx={{ cursor: "pointer" }}
+        sx={{ 
+          cursor: "pointer",
+          transition: 'transform 0.2s ease-in-out',
+          '&:hover': {
+            transform: 'scale(1.02)',
+          },
+          '&:active': {
+            transform: 'scale(0.98)',
+          }
+        }}
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 07a918b and 67f158a.

📒 Files selected for processing (1)
  • Client/src/Components/Sidebar/index.jsx (1 hunks)

Client/src/Components/Sidebar/index.jsx Show resolved Hide resolved
@khd33j
Copy link
Author

khd33j commented Oct 24, 2024

I'll keep that in mind for next time. Again, I'm sorry for the inconvenience.

Copy link
Collaborator

@ajhollid ajhollid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for implementing that 👍

@@ -181,6 +181,8 @@ function Sidebar() {
direction="row"
alignItems="center"
gap={theme.spacing(4)}
onClick={() => window.open("https://github.com/bluewave-labs/bluewave-uptime", "_blank", "noreferrer")}
sx={{ cursor: "pointer" }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK on my end 👍

@ajhollid ajhollid merged commit 2223d82 into bluewave-labs:develop Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants