Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust Search Bar height #1341

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix: Adjust Search Bar height #1341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Client/src/Components/Inputs/Search/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ const Search = ({
{
borderColor: theme.palette.border.light,
},
"& .MuiOutlinedInput-root": {
paddingY: 0,
},
Comment on lines +96 to +98
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Yo dawg, we need to fix that height properly! 🍝

The current changes only set paddingY: 0 but don't explicitly set the height to 34px as required in issue #1322. This might not consistently achieve the desired height across different browsers and scenarios.

Let's fix this with proper height setting:

 "& .MuiOutlinedInput-root": {
-  paddingY: 0,
+  height: '34px',
+  '& input': {
+    height: '34px',
+    padding: '0 14px',
+  }
 },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"& .MuiOutlinedInput-root": {
paddingY: 0,
},
"& .MuiOutlinedInput-root": {
height: '34px',
'& input': {
height: '34px',
padding: '0 14px',
}
},

}}
/>
{error && (
Expand Down