Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency react-redux to v9.2.0 #1353

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(deps): update dependency react-redux to v9.2.0 #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions Client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"jwt-decode": "^4.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-redux": "9.1.2",
"react-redux": "9.2.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Yo dawg, we've got a compatibility issue that's heavier than mom's spaghetti! 🍝

The react-redux 9.2.0 requires Redux v5 as a peer dependency, but we don't have Redux directly installed - we're only using @reduxjs/toolkit. While our Redux usage through @reduxjs/toolkit looks clean (no deprecated APIs), we need to ensure our toolkit version is compatible with Redux v5.

  • Add Redux v5 as a direct dependency: "redux": "^5.0.0"
  • Consider updating @reduxjs/toolkit to ensure full Redux v5 compatibility
🔗 Analysis chain

Yo dawg, this update looks solid but let's double-check some things!

The update to react-redux 9.2.0 is cool, but we should verify the peer dependencies and React compatibility.

Let's run this script to check the peer dependencies and compatibility:

The peer dependency check shows react-redux 9.2.0 requires Redux v5, so we need to verify our Redux version and any potential breaking changes in usage. Yo, let's check this before dropping the final verdict! 🍝

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check peer dependencies and compatibility

# Get package details from npm
curl -s https://registry.npmjs.org/react-redux/9.2.0 | jq '.peerDependencies'

# Check if any other packages in the project have conflicting peer dependencies
for pkg in "@reduxjs/toolkit" "redux-persist"; do
  echo "Checking $pkg peer dependencies..."
  curl -s "https://registry.npmjs.org/$pkg/$(jq -r ".dependencies[\"$pkg\"]" Client/package.json)" | jq '.peerDependencies'
done

Length of output: 865

Script:

#!/bin/bash
# Let's check the current versions of react and redux in package.json
cat Client/package.json | jq '.dependencies | {react, redux}'

# Also check if there are any direct usages of redux v5 specific APIs
rg -g '*.{js,jsx,ts,tsx}' 'createStore|combineReducers|applyMiddleware|compose' -A 2

Length of output: 601

"react-router": "^6.23.0",
"react-router-dom": "^6.23.1",
"react-toastify": "^10.0.5",
Expand Down