-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update demo server URLs to 'checkmate-demo.bluewavelabs.ca' #1364
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ It regularly checks whether a server/website is accessible and performs optimall | |
|
||
## Demo | ||
|
||
We have a [demo](https://uptime-demo.bluewavelabs.ca/) where you can test how the Uptime Manager works. The username is [[email protected]](mailto:[email protected]) and the password is Demouser1! | ||
We have a [demo](https://checkmate-demo.bluewavelabs.ca/) where you can test how the Uptime Manager works. The username is [[email protected]](mailto:[email protected]) and the password is Demouser1! | ||
|
||
## Questions & ideas | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -201,7 +201,7 @@ Our API is documented in accordance with the [OpenAPI spec](https://www.openapis | |
|
||
You can see the documentation on your local development server at http://localhost:{port}/api-docs | ||
|
||
You can also view the documentation on our demo server at [https://uptime-demo.bluewavelabs.ca/api-docs](https://uptime-demo.bluewavelabs.ca/api-docs) | ||
You can also view the documentation on our demo server at [https://checkmate-demo.bluewavelabs.ca/api-docs](https://checkmate-demo.bluewavelabs.ca/api-docs) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Yo dawg, we got a 301 redirect situation with that API docs URL! Listen up, the URL's giving us a 301 redirect (that's a permanent move), and I noticed it wants a trailing slash. Plus, I found the new But here's the deal:
🔗 Analysis chainYo, the URL update looks solid! Let's verify it's working though. The URL change from uptime-demo to checkmate-demo aligns perfectly with the PR objectives. Just wanna make sure it's actually accessible. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if the new demo server URL is accessible
# Expected: 200 OK response
curl -I https://checkmate-demo.bluewavelabs.ca/api-docs
Length of output: 553 Script: #!/bin/bash
# Let's check if there are any other occurrences of the old or new demo URLs in the codebase
rg -i "uptime-demo.bluewavelabs.ca|checkmate-demo.bluewavelabs.ca" -A 2 -B 2
Length of output: 5212 |
||
|
||
### Error handling | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Yo, hold up! There's a domain mismatch that's making me nervous!
The test environment's Nginx configuration uses
checkmate-test.bluewavelabs.ca
as the server name, but the API URL in the docker-compose is set tocheckmate-demo.bluewavelabs.ca
. This inconsistency could cause connectivity issues:Docker/test/nginx/conf.d/default.conf
usescheckmate-test.bluewavelabs.ca
Docker/test/docker-compose.yaml
usescheckmate-demo.bluewavelabs.ca
The test environment should consistently use the test domain across all configurations to maintain proper separation from production.
🔗 Analysis chain
Straight outta consistency check!
The environment variable update matches the prod configuration, maintaining consistency across environments. However, using the same domain for both test and prod environments might cause confusion.
Consider using different subdomains for test and prod environments (e.g.,
test.checkmate-demo
vscheckmate-demo
) to prevent confusion.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 45
Script:
Length of output: 2639