updated tests for full coverage #957
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request focus on enhancing the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const error = new Error("jwt.sign error"); | ||
| stub = sinon.stub(jwt, "sign").throws(error); | ||
| const payload = { id: "123" }; | ||
| const appSettings = { jwtSecret: "my_secret" }; |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
|
|
||
| it("should return a token if jwt.sign is successful and appSettings.jtwTTL is not defined", () => { | ||
| const payload = { id: "123" }; | ||
| const appSettings = { jwtSecret: "my_secret" }; |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
|
|
||
| it("should return a token if jwt.sign is successful and appSettings.jwtTTL is defined", () => { | ||
| const payload = { id: "123" }; | ||
| const appSettings = { jwtSecret: "my_secret", jwtTTL: "1s" }; |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
This PR updates some authController tests to provide full test coverage