Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a skeleton page to Infrastructure monitoring > Details page #1187

Closed
gorkem-bwl opened this issue Nov 23, 2024 · 3 comments
Closed

Add a skeleton page to Infrastructure monitoring > Details page #1187

gorkem-bwl opened this issue Nov 23, 2024 · 3 comments
Labels
design Design related frontend good first issue Good for newcomers
Milestone

Comments

@gorkem-bwl
Copy link
Contributor

When a user clicks on a server detail on the Monitoring page, a skeleton loader is displayed initially, followed by the full page content. We need to implement a similar approach on the Infrastructure Monitoring page. When a user accesses the server details (infra monitoring), a skeleton loader should appear before the content is loaded.

The most efficient way to achieve this is by replicating the implementation from the Monitor > Details page.

This is due 2.0 so needs to be taken care of in a few days or so.

@gorkem-bwl gorkem-bwl added good first issue Good for newcomers design Design related frontend labels Nov 23, 2024
@gorkem-bwl gorkem-bwl added this to the 2.0 milestone Nov 23, 2024
@gorkem-bwl
Copy link
Contributor Author

@DemonicQuasar
Copy link
Contributor

Hi there, can I take this? Thanks

@ajhollid
Copy link
Collaborator

Hi @DemonicQuasar, there's actually a PR open for this issue already, but thanks for the offer to help!

If you'd like you can review the PR, we always appreciate PR reviews!

ajhollid added a commit that referenced this issue Nov 25, 2024
add safety checks and simple empty view for details page, addresses #1187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design related frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants