Add from iterator impl #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbu-
reviewed
Jan 31, 2025
| Err(_) => return Err(CapacityError::new(())), | ||
| } | ||
| } | ||
| self.set_len(len); |
There was a problem hiding this comment.
Why is this implemented as unsafe instead of using ArrayString::try_push?
There was a problem hiding this comment.
Because I think that this function should be as performant as possible, and calling try_push will modify the len on every iteration. This way we can set it once when we're done, which seems to be more efficient.
There was a problem hiding this comment.
Could you write a quick benchmark verifying that this improves performance over the naive try_push loop?
There was a problem hiding this comment.
Sure, here are results on my machune:
test try_extend_bench ... bench: 28 ns/iter (+/- 2) = 146285 MB/s
test try_push_loop ... bench: 336 ns/iter (+/- 13) = 12190 MB/s
I also fixed the other benches (at they were all optimized on my machine in just one LOAD of a capacity constant)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the best effort implementation that allows pushing iterator into
ArrayString. There is noTryFromIteratortrait yet andTryFrom<I>breaks blanketTryFrom<T>impl in std, so this is the next best thing - just a couple of inherent struct functions.Related #142