Skip to content

Commit

Permalink
Fix tests from build bump
Browse files Browse the repository at this point in the history
- Some build errors report changed
- CamelCase in task{,run} name is not allowed

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester authored and knative-prow-robot committed Jan 24, 2019
1 parent 54d2a9b commit 35d4d60
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions pkg/apis/pipeline/v1alpha1/task_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ func TestTaskSpec_ValidateError(t *testing.T) {
},
},
expectedError: apis.FieldError{
Message: `missing field(s)`,
Paths: []string{"b.spec.template"},
Message: `expected exactly one, got neither`,
Paths: []string{"template", "steps"},
},
}, {
name: "one invalid input",
Expand Down Expand Up @@ -242,8 +242,8 @@ func TestTaskSpec_ValidateError(t *testing.T) {
BuildSteps: []corev1.Container{},
},
expectedError: apis.FieldError{
Message: "missing field(s)",
Paths: []string{"b.spec.template"},
Message: "expected exactly one, got neither",
Paths: []string{"template", "steps"},
},
}, {
name: "invalid build step name",
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconciler/v1alpha1/taskrun/taskrun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ func TestReconcile(t *testing.T) {
),
),
)
taskRunWithTaskSpec := tb.TaskRun("test-taskrun-with-taskSpec", "foo", tb.TaskRunSpec(
taskRunWithTaskSpec := tb.TaskRun("test-taskrun-with-taskspec", "foo", tb.TaskRunSpec(
tb.TaskRunInputs(
tb.TaskRunInputsParam("myarg", "foo"),
tb.TaskRunInputsResource("workspace", tb.TaskResourceBindingRef(gitResource.Name)),
Expand Down

0 comments on commit 35d4d60

Please sign in to comment.