Skip to content

Commit

Permalink
Add Results fields to TaskRun and PipelineRun status
Browse files Browse the repository at this point in the history
When a user kicks off a run, they will provide an endpoint to upload
logs to (initial implementation will be in #107). The corresponding
fields in `status` will indicate where the logs actually got uplaoded
to.

Once we actually get to #107, and especially once we start supporting
endpoints other than GCS, we may find this isn't useful and remove it.

Fixes tektoncd#146
  • Loading branch information
bobcatfish committed Dec 1, 2018
1 parent 2919c18 commit a01e6f4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/apis/pipeline/v1alpha1/pipelinerun_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ type PipelineTriggerRef struct {
// PipelineRunStatus defines the observed state of PipelineRun
type PipelineRunStatus struct {
Conditions duckv1alpha1.Conditions `json:"conditions"`
// In #107 should be updated to hold the location logs have been uploaded to
Results Results `json:"results"`
// map of TaskRun Status with the taskRun name as the key
//+optional
TaskRuns map[string]TaskRunStatus `json:"taskRuns,omitempty"`
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/pipeline/v1alpha1/taskrun_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ type TaskRunStatus struct {
// +optional
Conditions duckv1alpha1.Conditions `json:"conditions,omitempty"`

// In #107 should be updated to hold the location logs have been uploaded to
Results Results `json:"results"`

// PodName is the name of the pod responsible for executing this task's steps.
PodName string `json:"podName"`

Expand Down

0 comments on commit a01e6f4

Please sign in to comment.