Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zip archive not recognized #52

Closed
jdm opened this issue Nov 29, 2021 · 4 comments
Closed

Zip archive not recognized #52

jdm opened this issue Nov 29, 2021 · 4 comments

Comments

@jdm
Copy link

jdm commented Nov 29, 2021 •
edited
Loading

https://www.digitalmzx.com/download/544/c48ebe20995cd217d62776aeb4c90cb57872377a2c6e83cacc7d714360053e82/ is an archive that starts with 50 4b 30 30. The file command reports Zip archive data for it, and the macOS unarchiver opens it without issue. is_zip returns false for it, however.
@jdm
Copy link
Author

jdm commented Nov 29, 2021

Interestingly, immediately following those first four bytes is the expected 50 4b 03 04.

@jdm
Copy link
Author

jdm commented Nov 29, 2021

According to https://hybridego.net/m/entry/File-Header?category=185127 50 4b 30 30 50 4b 03 04 is a winzip archive.

@jdm
Copy link
Author

jdm commented Nov 29, 2021

https://stackoverflow.com/questions/12039237/how-to-check-if-zip-file-is-split-across-multiple-archives-using-pythons-zipfil explains why this difference exists.

@marcospb19
Copy link
Contributor

Related to #49? Hmm

@bojand bojand closed this as completed in ef12bb4 Jul 2, 2022
bojand added a commit that referenced this issue Jul 2, 2022
@bojand
Merge pull request #69 from bojand/winzip
d00c574 
add support for winzip in is_zip. fixes #52 and possibly #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @marcospb19