add global functions for a full static experience #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a runtime `Infer` instance is only needed when one need to add custom matchers. Let's have a full static experience and allow for a simpler usage.
| pub fn get(&self, buf: &[u8]) -> Option<Type> { | ||
| for (_, mime, ext, matcher) in self.iter_matchers() { | ||
| if matcher(buf) { | ||
| if matcher.0(buf) { |
There was a problem hiding this comment.
I think having a function on WrapMatcher called like matches(buf: &[u8]) -> bool would make this code a bit clearer. What do you think?
There was a problem hiding this comment.
ops didn't want to send a github suggestion
There was a problem hiding this comment.
Indeed I am not a fan of the WrapMatcher solution but this is all I have for having a conf fn new(). Maybe we could address this in the work you are planing to use a struct instead of a tuple here ?
There was a problem hiding this comment.
Sure, I can do that there. Since I already wrote it I'll have to rebase it anyway to make it use WrapMatcher https://github.com/paolobarbolini/infer/tree/refactor-1 so no problem.
paolobarbolini
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a runtime
Inferinstance is only neededwhen one need to add custom matchers.
Let's have a full static experience and allow
for a simpler usage.
See also #11 for the start of the discussion.
Having a 4 eyes check here would be greatly appreciated since I did a lot of copy pasting.
Cheers !