Improve detection of mov files (video/quicktime). #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes detection of mov files produced by Nikon cameras (and probably some other atypical muxers). The first 4 bytes of a mov file specify the size of the 'ftyp' atom. While typically the "Compatible_Brands[]" array contains just the "qt " brand and the size is 0x14, muxers are free to add an arbitrary number of brand markers, changing the size. For example, Nikon cameras add the brand "niko". See https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap1/qtff1.html#//apple_ref/doc/uid/TP40000939-CH203-39017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes detection of mov files produced by Nikon cameras (and probably some
other atypical muxers).
The first 4 bytes of a mov file specify the size of the 'ftyp' atom. While
typically the "Compatible_Brands[]" array contains just the "qt " brand and
the size is 0x14, muxers are free to add an arbitrary number of brand markers,
changing the size. For example, Nikon cameras add the brand "niko".
See https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap1/qtff1.html#//apple_ref/doc/uid/TP40000939-CH203-39017