fix(errorManagement) do not fail with an exception when the request s…

…tatus is not successful (#46) * Log a warning instead of throwing an exception * Error should be handled at process level using the `status code` connector output
bonitasoft · Nov 18, 2020 · 081a76d · 081a76d
1 parent 6931d46
commit 081a76d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/main/java/org/bonitasoft/connectors/rest/RESTConnector.java b/src/main/java/org/bonitasoft/connectors/rest/RESTConnector.java
@@ -522,9 +522,8 @@ public void execute(final Request request) throws Exception {
             LOGGER.fine("Response recieved.");
             final int statusCode = httpResponse.getStatusLine().getStatusCode();
             if (!statusSuccessful(statusCode)) {
-                throw new ConnectorException(
-                        String.format("%s response status is not successful: %s - %s", request, statusCode,
-                                httpResponse.getStatusLine().getReasonPhrase()));
+                LOGGER.warning(() -> String.format("%s response status is not successful: %s - %s", request, statusCode,
+                        httpResponse.getStatusLine().getReasonPhrase()));
             }
             setOutputs(httpResponse, request);
         } finally {

diff --git a/src/test/java/org/bonitasoft/connectors/rest/RESTConnectorTest.java b/src/test/java/org/bonitasoft/connectors/rest/RESTConnectorTest.java
@@ -919,8 +919,8 @@ public void basicAuthWithUsernamePasswordAndRealm() throws BonitaException {
      */
     @Test
     public void noServiceAvailable() throws BonitaException {
-        thrown.expect(ConnectorException.class);
-        executeConnector(buildMethodParametersSet(GET));
+        Map<String, Object> output = executeConnector(buildMethodParametersSet(GET));
+        assertEquals(404, output.get(RESTConnector.STATUS_CODE_OUTPUT_PARAMETER));
     }
 
     /**