[FEAT/#4] P2P 연결을 위한 클래스들을 구현합니다. (WebSocket, Signaling, WebRTC, Connection) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- secrets 추적 해제 Co-Authored-By: Youngkyu Song <[email protected]> Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
- BASE_URL 추가 - WebSocketClient (일단)구현 Co-Authored-By: Youngkyu Song <[email protected]> Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Youngkyu Song <[email protected]> Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Youngkyu Song <[email protected]> Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Youngkyu Song <[email protected]> Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Youngkyu Song <[email protected]> Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
- http 서버 대응 Co-Authored-By: Youngkyu Song <[email protected]> Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: seuhong <[email protected]> Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Closed
1 task
hsw1920
reviewed
Nov 12, 2024
PhotoGether/DataLayer/PhotoGetherNetwork/PhotoGetherNetwork/ConnectionClient.swift
Show resolved
Hide resolved
hsw1920
reviewed
Nov 12, 2024
PhotoGether/DataLayer/PhotoGetherNetwork/PhotoGetherNetwork/ConnectionClient.swift
Show resolved
Hide resolved
hsw1920
reviewed
Nov 12, 2024
PhotoGether/DataLayer/PhotoGetherNetwork/PhotoGetherNetwork/ConnectionClient.swift
Show resolved
Hide resolved
hsw1920
reviewed
Nov 12, 2024
PhotoGether/DataLayer/PhotoGetherNetwork/PhotoGetherNetwork/IceCandidate.swift
Show resolved
Hide resolved
hsw1920
reviewed
Nov 12, 2024
PhotoGether/DataLayer/PhotoGetherNetwork/PhotoGetherNetwork/SignalingClient.swift
Show resolved
Hide resolved
hsw1920
reviewed
Nov 12, 2024
PhotoGether/DataLayer/PhotoGetherNetwork/PhotoGetherNetwork/WebRTCClient.swift
Show resolved
Hide resolved
hsw1920
reviewed
Nov 12, 2024
PhotoGether/DataLayer/PhotoGetherNetwork/PhotoGetherNetwork/WebRTCClient.swift
Show resolved
Hide resolved
0Hooni
reviewed
Nov 12, 2024
...esentationLayer/WaitingRoomFeature/WaitingRoomFeature/Source/WaitingRoomViewController.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
P2P 연결을 위한 기능을 구현해야 했습니다.
📃 작업 내역
시그널링 과정을 진행하기 위해 필요한 클래스와 타입을 구현했습니다.
타입
SessionDescription(SDP)타입 구현IceCandidate타입 구현SignalingMessage타입 구현클래스 및 프로토콜
WebSocketClient및WebSocketClientDelegate구현SignalingCilent및SignalingClientDelegate구현WebRTCClientWebRTCClientDelegate구현ConnectionClient구현✅ 리뷰 노트
살려주세요.
🎨 스크린샷
도메인 작업만 진행해 스크린샷이 없습니다ㅜ
🚀 테스트 방법
URLProtocol을 이용해 소켓 통신 요청을 가로채는 Mock객체를 만들어 테스트를 진행하려했습니다.
XCTest 객체를 URLSessionWebSocketDelegate 채택해 콜백을 받으려 했지만, 호출되지 않는 문제가 있었고, 3시간 이상 트러블 슈팅을 해봤습니다.
하지만 성공하지 못했고, 작업 우선순위에 따라 다른 작업을 진행했습니다. 🥲