[FEAT/#62] 스티커 API 연결 및 Entity에 맞게 일부 코드 수정 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 테스트 코드 수정 - Mock 객체 수정
- 테스트를 위한 Demo가 Data 의존을 하도록 추가함
Co-Authored-By: seuhong <[email protected]>
3 tasks
hsw1920
approved these changes
Nov 20, 2024
PhotoGether/DataLayer/PhotoGetherData/PhotoGetherData/RemoteShapeDataSourceImpl.swift
Show resolved
Hide resolved
| import PhotoGetherDomainInterface | ||
|
|
||
| final public class ShapeRepositoryImpl: ShapeRepository { | ||
| // TODO: local 먼저 확인 -> remote 데이터 확인하도록 수정 |
There was a problem hiding this comment.
이부분 다른 팀원분들 의견도 궁금합니다!
local에는 캐시가 있고 먼저 확인할 예정입니다.
...omainLayer/PhotoGetherDomain/FetchStickerListUseCaseTests/FetchStickerListUseCaseTests.swift
Outdated
Show resolved
Hide resolved
PhotoGether/DomainLayer/PhotoGetherDomain/PhotoGetherDomainInterface/Model/StickerEntity.swift
Outdated
Show resolved
Hide resolved
Kiyoung-Kim-57
approved these changes
Nov 21, 2024
| } | ||
|
|
||
| private func imageData(named: String) -> Data? { | ||
| private func imageData(named: String) -> String { |
There was a problem hiding this comment.
Data 리턴에서 path 리턴으로 바뀌었군요! 그럼 메서드 이름도 imagePath로 바꾸는건 어떨까요?
There was a problem hiding this comment.
해당 커밋에서 수정하였습니다!
PhotoGether/DataLayer/PhotoGetherData/PhotoGetherData/RemoteShapeDataSourceImpl.swift
Show resolved
Hide resolved
Kiyoung-Kim-57
added a commit
that referenced
this pull request
Nov 25, 2024
- Repository에 LocalVideoView를 생성하면서 연관된 UseCase들을 수정했습니다. Co-Authored-By: Youngkyu Song <[email protected]>
Kiyoung-Kim-57
added a commit
that referenced
this pull request
Nov 25, 2024
- 딥링크를 통해 들어온 유저가 방 번호와 호스트 유저 아이디를 파싱할 수 있도록 구현 Co-Authored-By: Youngkyu Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
✅ 리뷰 노트
3-layer-architechture에 기반하여 동작할 수 있도록 fetchSticker를 설계했습니다.
이 부분에서 조금 러닝 커브가 발생하였어서 후반 커밋은 @hsw1920 님과 같이 설계를 했습니다.
스스로 구현하면서도 부족함이 느껴져서 조금이라도 수정하거나,
좀 더 좋은 스타일이 있는지 봐주시며 피드백 해주시면 감사하겠습니다!
🎨 스크린샷
🚀 테스트 방법
EditPhotoRoomFeatureDemo 앱을 실행한 뒤 스티커 버튼을 누르면 랜덤한 스티커를 가져옵니다.