Suppress build: masm
logo and clang
warning argument unused during compilation
#288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for: #286 and #287
Concern
These changes are applied to implementation
fcontext
(that is being set for me):Maybe old code + new mine should affect other implementations (
ucontext
,winfib
) too, maybe not - I don't know.Further
There still MASM output that informs/repeats the build file, looks like modern VS 2022 17.7 Preview 1 is able to consume
/quiet
option forml
andml64
. But it is too modern :(https://gitlab.kitware.com/cmake/cmake/-/issues/23537#note_1316785
https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170
Version table
https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros
CMake - GREATER_EQUAL
Added in version 3.7: Added the LESS_EQUAL and GREATER_EQUAL options.
And context is 3.5:
if(NOT(MSVC_VERSION LESS 1936))
will it behttps://stackoverflow.com/questions/16667017/cmake-express-the-greater-or-equal-statement
Concern
It is better to check if we can pass
/quiet
on any 17.6 patch version, or better to set1937
to be 100% sure that it works.