Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overloads no longer required by Math. #623

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Remove overloads no longer required by Math. #623

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c865ff5
Remove overloads no longer required by Math.
jzmaddock Jun 14, 2024
b390a7d
Reinstate overloads, correct Policy usage.
jzmaddock Jun 15, 2024
f2887b0
Correct call.
jzmaddock Jun 15, 2024
26d1a29
Move overloads into correct namespace!
jzmaddock Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions include/boost/multiprecision/detail/default_ops.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3980,41 +3980,46 @@ ilogb(const detail::expression<tag, A1, A2, A3, A4>& val)
} //namespace multiprecision

namespace math {


//
// Overload of Boost.Math functions that find the wrong overload when used with number:
//
namespace detail {

template <class T>
T sinc_pi_imp(T);
template <class T>
T sinhc_pi_imp(T);
template <class T, class Policy>
T sinhc_pi_imp(T, const Policy&);

} // namespace detail

template <class Backend, multiprecision::expression_template_option ExpressionTemplates>
inline multiprecision::number<Backend, ExpressionTemplates> sinc_pi(const multiprecision::number<Backend, ExpressionTemplates>& x)
{
boost::multiprecision::detail::scoped_default_precision<multiprecision::number<Backend, ExpressionTemplates> > precision_guard(x);
return std::move(detail::sinc_pi_imp(x));
return detail::sinc_pi_imp(x);
}

template <class Backend, multiprecision::expression_template_option ExpressionTemplates, class Policy>
inline multiprecision::number<Backend, ExpressionTemplates> sinc_pi(const multiprecision::number<Backend, ExpressionTemplates>& x, const Policy&)
{
boost::multiprecision::detail::scoped_default_precision<multiprecision::number<Backend, ExpressionTemplates> > precision_guard(x);
return std::move(detail::sinc_pi_imp(x));
return detail::sinc_pi_imp(x);
}

template <class Backend, multiprecision::expression_template_option ExpressionTemplates>
inline multiprecision::number<Backend, ExpressionTemplates> sinhc_pi(const multiprecision::number<Backend, ExpressionTemplates>& x)
{
boost::multiprecision::detail::scoped_default_precision<multiprecision::number<Backend, ExpressionTemplates> > precision_guard(x);
return std::move(detail::sinhc_pi_imp(x));
return detail::sinhc_pi_imp(x, boost::math::policies::policy<>());
}

template <class Backend, multiprecision::expression_template_option ExpressionTemplates, class Policy>
inline multiprecision::number<Backend, ExpressionTemplates> sinhc_pi(const multiprecision::number<Backend, ExpressionTemplates>& x, const Policy&)
inline multiprecision::number<Backend, ExpressionTemplates> sinhc_pi(const multiprecision::number<Backend, ExpressionTemplates>& x, const Policy& pol)
{
boost::multiprecision::detail::scoped_default_precision<multiprecision::number<Backend, ExpressionTemplates> > precision_guard(x);
return std::move(boost::math::sinhc_pi(x));
boost::multiprecision::detail::scoped_default_precision<multiprecision::number<Backend, ExpressionTemplates> > precision_guard(x, pol);
return detail::sinhc_pi_imp(x, pol);
}

using boost::multiprecision::gcd;
Expand Down
Loading