Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

item.source is dual-use #2343

Closed
ThomasWaldmann opened this issue Mar 26, 2017 · 2 comments
Closed

item.source is dual-use #2343

ThomasWaldmann opened this issue Mar 26, 2017 · 2 comments
Assignees
@ThomasWaldmann
Labels
breaking later
Milestone
2.0.0a2

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Mar 26, 2017 •
edited
Loading

item.source is the symlink target for symlink items.
item.source is the hardlink master for hardlink slaves.
thus, we have a conflict for symlink items that are also hardlink slaves.

this should be cleaned up at a breaking time, hardlink slaves shall always use item.master to refer to the hardlink master.

see also: #2325
@ThomasWaldmann ThomasWaldmann changed the title item.source is dual use item.source is dual-use Mar 26, 2017
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Mar 26, 2017
@ThomasWaldmann
introduce Item.master to work around .source dual-use issue
be3461a 
see borgbackup#2343 for details.
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Mar 26, 2017
@ThomasWaldmann
fix symlink item fs size computation
5fa2831 
a symlink has a 'source' attribute, so it was confused with a hardlink
slave here. see also issue borgbackup#2343.

also, a symlink's fs size is defined as the length of the target path.
@ThomasWaldmann ThomasWaldmann mentioned this issue Mar 26, 2017
Merged
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Mar 26, 2017
@ThomasWaldmann
fix symlink item fs size computation
90dd0e8 
a symlink has a 'source' attribute, so it was confused with a hardlink
slave here. see also issue borgbackup#2343.

also, a symlink's fs size is defined as the length of the target path.
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Mar 28, 2017
@ThomasWaldmann
no hardlinking for directories and symlinks
17fbb74 
- nlink > 1 for dirs does not mean hardlinking
  (at least not everywhere, wondering how apple does it)
- we can not archive hardlinked symlinks due to item.source dual-use,
  see issue borgbackup#2343.

likely nobody uses this anyway.
@ThomasWaldmann ThomasWaldmann added this to the 2.0 - future goals milestone Mar 29, 2017
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Apr 1, 2017
@ThomasWaldmann
no hardlinking for directories and symlinks
56d921e 
- nlink > 1 for dirs does not mean hardlinking
  (at least not everywhere, wondering how apple does it)
- we can not archive hardlinked symlinks due to item.source dual-use,
  see issue borgbackup#2343.

likely nobody uses this anyway.
@ThomasWaldmann ThomasWaldmann mentioned this issue Apr 2, 2017
Closed
@enkore enkore added the later label Apr 4, 2017
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Apr 5, 2017
@ThomasWaldmann
no hardlinking for directories and symlinks
23cc679 
- nlink > 1 for dirs does not mean hardlinking
  (at least not everywhere, wondering how apple does it)
- we can not archive hardlinked symlinks due to item.source dual-use,
  see issue borgbackup#2343.

likely nobody uses this anyway.
@ThomasWaldmann ThomasWaldmann mentioned this issue Apr 16, 2022
Open
@ThomasWaldmann ThomasWaldmann mentioned this issue May 3, 2022
Closed
@ThomasWaldmann ThomasWaldmann self-assigned this May 6, 2022
@ThomasWaldmann
Copy link
Member Author

#6663 resolved this.

item.hlid is used to related hardlinks. item.source is not used any more for hardlinks.

@ThomasWaldmann ThomasWaldmann modified the milestones: fluorine, 2.0.0a2 Jun 26, 2022
@ThomasWaldmann
Copy link
Member Author

this is solved in borg2 branch, in 2.0.0a2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWaldmann ThomasWaldmann

Labels
breaking later
Projects
None yet
Milestone
2.0.0a2
Development

No branches or pull requests
2 participants
@ThomasWaldmann @enkore