Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hybrid uninitialized warning #2007

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jmackay2
Copy link
Contributor

There is an error when building on Ubuntu 24.04:

gtsam/examples/Hybrid_City10000.cpp:207:16: error: ‘key_t’ may be used uninitialized [-Werror=maybe-uninitialized]
  207 |   write_results(results, (key_t + 1), "HybridISAM_city10000.txt");

This solves the error by initializing key_t to remove the warning. This was tested by performing a successful build.

@varunagrawal
Copy link
Collaborator

So strange, I don't get this issue? What version of GCC are you using? It would behoove us to add a CI check with that version if it is stricter.

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@varunagrawal varunagrawal merged commit 4ba3df1 into borglab:develop Jan 28, 2025
35 checks passed
@jmackay2
Copy link
Contributor Author

So strange, I don't get this issue? What version of GCC are you using? It would behoove us to add a CI check with that version if it is stricter.

I'm on Ubuntu 24.04 with gcc 13.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants