Implement Resource Waiter Actions #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each resource that has a resource waiter definition a ``wait_until_...`` method was added to the resource. Documentation was updated as well to document both the resource waiter and client waiters.
|
LGTM 🚢-it! |
danielgtaylor
added
the
enhancement
kyleknap
added a commit
that referenced
this pull request
Dec 17, 2014
Implement Resource Waiter Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So for this PR, I expose waiter actions for resources. For each waiter action, the name was prepended with
wait_until_. So for the EC2 Instance resource definition, it has waiter resource definitions: "Running", "Stopped", and "Terminated": https://github.com/boto/boto3/blob/develop/boto3/data/resources/ec2-2014-10-01.resources.json#L694This gets translated to the methods:
wait_until_running(),wait_until_stopped(), andwait_until_terminated()for the Instance resource. These methods will then make await()call to the client's waiter method to actually perform the wait.cc @danielgtaylor @jamesls