Fix auth error when resigning requests #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it (almost) possbile to support retries in the client interface as well.
More fallout from reusing the same request object to resign a request. Before setting a value for a header, we need to first check if the key exists and delete it first, otherwise it's an append, not a replace, which will cause signing errors. Though not strictly required for some signers, I think it's important to be consistent and just state that before setting a header value, we should delete it first if it exists.
|
LGTM 🚢-it! |
| @@ -380,7 +384,7 @@ def base64_encode_user_data(params, **kwargs): | |||
| ('needs-retry.s3.CopyObject', check_for_200_error, REGISTER_FIRST), | |||
| ('needs-retry.s3.CompleteMultipartUpload', check_for_200_error, | |||
| REGISTER_FIRST), | |||
| ('service-created', register_retries_for_service), | |||
| ('service-data-loaded', register_retries_for_service), | |||
There was a problem hiding this comment.
Is this because the clients do not hit the 'serivce-created' event? Just curious.
There was a problem hiding this comment.
Nevermind, just read the overview of the PR. Question answered.
|
It looks good to me. 🚢 I just had a question about the assertion for one of the unit tests. |
This was referenced Nov 18, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fallout from reusing the same request object to resign
a request. Before setting a value for a header, we need to first
check if the key exists and delete it first, otherwise it's an
append, not a replace, which will cause signing errors.
Though not strictly required for some signers, I think it's important
to be consistent and just state that before setting a header value,
we should delete it first if it exists.
Couple of other things I noticed:
over to service-data-loaded in the hopes that we can make this accessible
to the client interface
suite of tests. These tests mock out the HTTPAdapter such that the first
attempt to send the request always triggers a ConnectionError (the second
attempt calls the original send() method). This ensures we are retrying
requests properly for all the services in the smoke tests.
cc @kyleknap @danielgtaylor