Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify endpoint's signature version #433

Merged
merged 2 commits into from
Jan 13, 2015

Conversation

kyleknap
Copy link
Contributor

Add option to pass signature_version to EndpointCreator's create_endpoint method.

When get_endpoint is called from Service objects, it will pass in its signature version to create_endpoint. That is required for the CLI's --no-sign-request flag to work because the handler changes the service object's signature version.

I will be sending a PR out real soon for the CLI, that will add a test to catch that --no-sign-request is adhered to.

cc @jamesls @danielgtaylor

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) when pulling 3d9ae51 on kyleknap:no-sign into 38faa0e on boto:develop.

@kyleknap
Copy link
Contributor Author

@jamesls Test now pass. I added a flag to check if the service object is using a custom signature version.

@jamesls
Copy link
Member

jamesls commented Jan 13, 2015

:shipit:

kyleknap added a commit that referenced this pull request Jan 13, 2015
Add option to specify endpoint's signature version
@kyleknap kyleknap merged commit 4198afa into boto:develop Jan 13, 2015
@kyleknap kyleknap deleted the no-sign branch January 13, 2015 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants