AWS_DATA_PATH should override customer/builtin data paths #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression introduced in 1225dc7. This was originally fixed in 0.68.0 of botocore. At this point, I think a functional test in warranted, as this did functionality did not surivive a refactoring, so I've added a basic functional test to ensure we don't regress on this in the future.
jamesls
added
the
pr/needs-review
|
🚢 |
|
|
|
🚢 |
|
|
||
|
|
||
| class TestLoaderAllowsDataPathOverride(unittest.TestCase): | ||
| def create_file(self, f, contents, name): |
There was a problem hiding this comment.
It would be cool if FileCreator was in botocore.
|
Looks good. 🚢 Just had a comment about something that would be cool to have in the future if we keep following this pattern of creating a file and cleaning it up in the tests. |
This was referenced Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression introduced in
1225dc7. This was
originally fixed in 0.68.0 of botocore.
At this point, I think a functional test in warranted,
as this did functionality did not surivive a refactoring,
so I've added a basic functional test to ensure we don't
regress on this in the future.
There were also a few tests that need to be updated with this change.
These tests were previously wrong but were not being caught
because of this bug.
cc @kyleknap @mtdowling @rayluo @JordonPhillips