Conditionalize source and mode in Bootstrap container template #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is blocked by #294 . |
vyaghras
force-pushed
the
enable-rendering-bootstrap-source
branch
from
be3af68 to
ee6bd96
Compare
bcressey
reviewed
Jan 31, 2025
vyaghras
changed the title
vyaghras
force-pushed
the
enable-rendering-bootstrap-source
branch
from
ee6bd96 to
90e8b3f
Compare
bcressey
approved these changes
Jan 31, 2025
We need to make source and mode optional. We are adding managed Bootstrap container in Bottlerocket, i.e source for Bootstrap container will be optional with managed Bootstrap container images. We can still provide the source that will take preferrence over the default Bootstrap container image.
vyaghras
force-pushed
the
enable-rendering-bootstrap-source
branch
from
90e8b3f to
8a9afd8
Compare
cbgbt
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Add a option in Bootstrap-containers binary to render the source for the Bootstrap container when unavailable. We will use the provided source if it is present.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.