package updates: aws-iam-authenticator to 0.6.29 and aws-signing-helper to 1.4.0 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koooosh
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Changes LGTM, but a nit on the commit messages, where we prefer:
- packages: update aws-iam-authenticator to 0.6.29
- packages: update aws-signing-helper to 1.4.0
Also, let's update the PR title to mention we are updating aws-iam-authenticator and aws-signing-helper specifically for clarification
Sparksssj
changed the title
koooosh
changed the title
koooosh
approved these changes
Feb 4, 2025
bcressey
reviewed
Feb 5, 2025
| @@ -49,7 +49,7 @@ Conflicts: (%{_cross_os}image-feature(no-fips) or %{name}-bin) | |||
|
|
|||
| %build | |||
| %set_cross_go_flags | |||
| export GO_MAJOR="1.22" | |||
| export GO_MAJOR="1.23" | |||
There was a problem hiding this comment.
Is this change strictly required to build? You are overriding the SDK default and it would be better to leave it alone if it's not required.
There was a problem hiding this comment.
In other words - I'd rather delete this line than change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updated aws-iam-authenticator to 0.6.29, and aws-signing helper to 1.4.0
Testing done:
Quick tests and smoke tests passed.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.