-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pubsys: add AMI registration/copying #1010
Conversation
^ This push fixes the coldsnap dependency in Cargo.toml to actually use it from crates.io. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦓
Also this is amazing, nice work! |
I'm not able to push the change until @zmrow's back, but this addresses @bcressey's feedback above: https://gist.github.com/tjkirch/b0ac076be189af44551a20f5c5bed7c5 Still able to make AMIs OK. |
^ This push addresses @bcressey's comments above, as in my gist above. |
^ This push is just a rebase on develop to fix conflicts. |
Pubsys subcommands do not use the same parts of Infra.toml, so they have to be optional if we want to have a common config file. The subcommands will confirm that the necessary fields are present.
^ This push is just a rebase on develop to fix CI. |
This lets you register an AMI from the latest build and copy it to a list of regions. Co-authored-by: Zac Mrowicki <[email protected]> Co-authored-by: Tom Kirchner <[email protected]>
^ This push moves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description of changes:
Infra.toml.example
was updated with the configuration needed for building AMIs; only a region list is necessary, and that can be overridden by specifying-e PUBLISH_REGIONS
if desired. You can also override the AMI name and volume sizes, if desired.Testing done:
Used
cargo make ami
to register single AMIs, register/copy AMIs in multiple regions, register with global and regional roles. A registered Bottlerocket aws-k8s-1.17 AMI ran/connected OK. Also rerancargo make repo
to ensure existing functionality wasn't affected by config change.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.