pubsys: fix bug preventing multiple ssm promotions #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
force-pushed
the
pubsys-ssm-file
branch
2 times, most recently
from
3069d94 to
945a00a
Compare
zmrow
approved these changes
May 23, 2023
| "test3-parameter-value".to_string(), | ||
| ), | ||
| ( | ||
| SsmKey::new( |
There was a problem hiding this comment.
This is just an additional key yeah? I'm not missing more context there?
There was a problem hiding this comment.
Correct! The idea was that this key isn't involved in the promotion.
This test would fail on the previous commit.
yeazelm
approved these changes
May 23, 2023
stmcginnis
approved these changes
May 23, 2023
stmcginnis
approved these changes
May 23, 2023
|
^ fixes clippy warnings. |
etungsten
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3103
Description of changes:
The goal of this feature is to keep a file of all published SSM parameters for the current Bottlerocket build.
During promotions, we parse the existing SSM file then add any newly created SSM parameter.
Prior to this change, the code which combines prior state with the newly-created parameters falsely assumed that all constructed promoted parameters would have a 1:1 mapping with a parameter that already exists in the file. This fails in some cases, e.g. when performing tiered promotions where the first tier is largely irrelevant when performing a promotion from the second to the third tier.
The change modifies the code to simply concatenate the existing data with any newly-created parameter, overwriting if the key exists.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.