Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: add updates settings extension #3689

Conversation

sam-berning
Copy link
Contributor

Issue number:

Closes #3649

Description of changes:

Adds an settings extension for updates settings

Testing done:

  • Built aws-dev with the settings extension package included, spun up an ec2 instance with the resulting AMI.

  • Updates settings (including the seed generated by bork) looked as expected

  • /usr/libexec/settings/updates worked as expected:

bash-5.1# /usr/libexec/settings/updates proto1 generate --setting-version v1
{
  "Complete": {
    "seed": 722
  }
}
bash-5.1# /usr/libexec/settings/updates proto1 set --setting-version v1 --value '{"seed": 24, "ignore-waves": true}'

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@sam-berning sam-berning force-pushed the update-settings-extension-rebase branch from 5f96aee to 531fbba Compare January 3, 2024 19:43
@sam-berning sam-berning requested a review from cbgbt January 3, 2024 19:44
@sam-berning sam-berning force-pushed the update-settings-extension-rebase branch from 531fbba to 4f722a1 Compare January 3, 2024 22:20
@jpculp jpculp mentioned this pull request Jan 4, 2024
11 tasks
@sam-berning sam-berning merged commit 481fa35 into bottlerocket-os:develop Jan 4, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOTB: Port updates settings model to settings extensions
3 participants