-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings extension #4050
Merged
Merged
Settings extension #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsharm
force-pushed
the
settings-extension
branch
4 times, most recently
from
June 11, 2024 05:49
04c3283
to
000efc7
Compare
mgsharm
force-pushed
the
settings-extension
branch
from
June 11, 2024 06:40
000efc7
to
ff4979d
Compare
Would you be able to do some instance testing as well? Just to be sure everything boots as expected since we are touching |
mgsharm
force-pushed
the
settings-extension
branch
from
June 11, 2024 17:55
76093e8
to
4e1534f
Compare
webern
approved these changes
Jun 11, 2024
cbgbt
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
bcressey
reviewed
Jun 11, 2024
bcressey
reviewed
Jun 11, 2024
mgsharm
force-pushed
the
settings-extension
branch
from
June 12, 2024 04:06
a73c328
to
f9869d9
Compare
Addressed comments. |
bcressey
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3651 #3652 #3650 #3663 #3666 #3664
Description of changes:
bootstrap_containers
,network
,host_containers
andautoscaling
settings extension and uses it in every variant's settings model.Testing done:
bootstrap_containers
network
host_containers
autoscaling
conatiner_runtime
oci_defaults
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.