[DRAFT] Nvidia Settings API changes #4125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Aug 5, 2024
Release.toml
Outdated
| @@ -1,4 +1,4 @@ | |||
| version = "1.21.0" | |||
| version = "1.21.1" | |||
There was a problem hiding this comment.
Typically we would not add new settings to the API in a point release. These changes should target 1.22. But don't do the release version bump in a feature PR, it's not really related to your feature and creates some churn.
sources/settings-migrations/v1.21.1/nvidia-k8s-device-plugin-settings/src/main.rs
Outdated
Show resolved
Hide resolved
sources/settings-migrations/v1.21.1/nvidia-k8s-device-plugin-metadata/src/main.rs
Outdated
Show resolved
Hide resolved
sources/settings-migrations/v1.21.1/nvidia-container-runtime-settings/src/main.rs
Show resolved
Hide resolved
sources/settings-migrations/v1.21.1/nvidia-k8s-device-plugin-settings/src/main.rs
Show resolved
Hide resolved
monirul
force-pushed
the
nvidia-api-kit
branch
5 times, most recently
from
4b97b65 to
20f5ffc
Compare
bcressey
reviewed
Aug 8, 2024
| -p settings-plugin-aws-k8s-nvidia \ | ||
| %{nil} | ||
|
|
||
|
|
There was a problem hiding this comment.
remove one of the two newlines:
Suggested change
|
|
||
| %description aws-k8s-nvidia | ||
| %{summary}. | ||
|
|
There was a problem hiding this comment.
avoid adding unnecessary whitespace:
Suggested change
|
I spoke with @monirul yesterday about an idea to programmatically verify that feature unification has not taken place. Since we need to do a settings-sdk release for the new models anyways, I think it would be a good idea to make the requisite changes their too. The basic idea is:
|
monirul
force-pushed
the
nvidia-api-kit
branch
from
20f5ffc to
6c7ab5f
Compare
monirul
force-pushed
the
nvidia-api-kit
branch
from
6c7ab5f to
8adc19c
Compare
|
This was superseded by #4182. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
This PR introduces new settings API for Nvidia GPUs for Kubernetes Nvidia variants.
New settings are
settings.nvidia-container-runtime.visible-devices-as-volume-mountsaccept-nvidia-visible-devices-as-volume-mountsvalue for k8s container-toolkittrue|falsedefault:truesettings.nvidia-container-runtime.visible-devices-envvar-when-unprivilegedaccept-nvidia-visible-devices-envvar-when-unprivilegedsettings of nvidia container runtime for k8s varienttrue|falsedefault:falsesettings.kubernetes.device-plugins.nvidia.pass-device-specspass-device-specssettings of the device plugin that pass the list of DeviceSpecs to the kubelet on Allocatetrue|falsedefault:truesettings.kubernetes.device-plugins.nvidia.device-id-strategydevice-id-strategysettings of the device plugin which specifies how GPUs are identified and selected for workloads running in a Kubernetes clusteruuid|indexDefault:indexsettings.kubernetes.device-plugins.nvidia.device-list-strategydevice-list-strategysetting in NVIDIA Kubernetes device plugins. It is used to configure how GPUs are listed and allocated to pods in a Kubernetes clusterenvvar|volume-mountsdefault:volume-mountsTesting done:
Yes.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.