Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws-creds settings defaults to all AWS variants #4285

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ginglis13
Copy link
Contributor

Issue number:

Related: #1667

Description of changes:

The aws-ecs-* and aws-dev variants do not include the aws-creds settings defaults by default. Add these settings as defaults for these variants. This ensures that these corresponding FIPS variants will include the changes from #4268 and
bottlerocket-os/bottlerocket-core-kit#218

Testing done:

Launch each variant affected by this change, ensure settings.aws appears as expected.

[ssm-user@control]$ apiclient get settings.aws
{
  "settings": {
    "aws": {
      "profile": "default",
      "region": "us-west-2"
    }
  }
}

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

The aws-ecs-* and aws-dev variants do not include the aws-creds settings
defaults by default. Add these settings as defaults for these variants.

Signed-off-by: Gavin Inglis <[email protected]>
@ginglis13 ginglis13 merged commit 4fbc16a into bottlerocket-os:develop Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants