Add implicit keyboard binding / migrate to diagram-js@15 #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skaiir
force-pushed
the
new-diagram-js-binding
branch
2 times, most recently
from
fe4d7ff
to
89799a3
Compare
|
Diagram-js@15 has been released. To support the migration, I will make sure this PR is mergable. |
barmac
force-pushed
the
new-diagram-js-binding
branch
2 times, most recently
from
1b8d8bd
to
0eaa0f2
Compare
barmac
force-pushed
the
new-diagram-js-binding
branch
from
0eaa0f2
to
45df343
Compare
barmac
changed the title
barmac
force-pushed
the
new-diagram-js-binding
branch
from
45df343
to
6cd54a9
Compare
This updates the library to diagram-js@15 which ships breaking changes. BREAKING CHANGES: * Keyboard is now implicitly bound to the container element. Calls to `keyboard.bind` with `node` and `keyboard.bindTo` now result with a descriptive console error and have no effect. Related to bpmn-io/diagram-js#662
barmac
force-pushed
the
new-diagram-js-binding
branch
from
6cd54a9
to
f04edca
Compare
bpmn-io-tasks
bot
added
needs review
|
Ready to review @Skaiir @vsgoulart |
barmac
requested review from
a team and
Skaiir
and removed request for
a team
|
Since I am only contributing here, please merge when you're ready. |
1 task
nikku
reviewed
Nov 19, 2024
|
|
||
| // focus container on over if no selection | ||
| container.addEventListener('mouseover', function () { | ||
| if (document.activeElement === document.body) { |
There was a problem hiding this comment.
We could / should use Canvas#restoreFocus() here.
nikku
reviewed
Nov 19, 2024
| // inside; this follows input focus handling closely | ||
| container.addEventListener('click', function (event) { | ||
| // force focus when clicking container | ||
| if (!container.contains(document.activeElement)) { |
There was a problem hiding this comment.
We could / should use Canvas#restoreFocus() here.
|
I could not not break it either, and the integration speaks to the simplicity of this thing. Great job 👏 Added two comments #1269 (comment), we probably cannot follow up on those, as we don't use the canvas, right? |
|
Indeed, there is no canvas in form-js :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the library to diagram-js@15 which ships breaking changes.
BREAKING CHANGES:
Calls to
keyboard.bindwithnodeandkeyboard.bindTonow result with a descriptive console error and have no effect.
Related to bpmn-io/diagram-js#662