Upgrade to support .NET Core #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bradymholt Any concerns / updates regarding this pull request so far? |
|
@yegor-n-a @crazycrank @simonpinn @efranzinelli @thechups @robbaman @mwhitty - Would one of you be willing to vet and test this PR? |
|
@bradymholt At the moment, the project includes neither unit nor integration tests. Did you mean, smoke testing or something much more substantial? |
|
@yegor-n-a - Yes, smoke test and manual testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brady,
Seeing that you were open to take a PR for a .NET Core framework upgrade, I thought I would oblige :)
This has been really straightforward, it's mostly been a matter of upgrading to the new VS 2017 .csproj format and adjusting the targetting for net45, netcoreapp2 frameworks.
That means that you will not be able to open the project from VS 2015, but I'd say that it's worth doing the jump after seeing how much of the verbose XML disappears.
netstandardI have targetednetcoreappas that is a requirement ofMicrosoft.SqlServer.SqlManagementObjectsThe project will now generate two separate builds for both frameworks, so you should be able to keep supporting .NET 4.5 once you publish the library.
Matter of fact is that I have not touched the console project that you have for testing, and it seems to be accepting the new build just fine.
The only caveat is that without unit tests nor the "mdf" file that you use in
Program.csI don't have an easy way to test this in full.Nevertheless, I can confirm that it builds, runs, and that I could attach a debugger without issues.
The one massively obvious recommendation would be to ensure that you fully test it with an actual database.
I'm also completely new to DbUp, so I don't have any existing migrations to use.
Lastly, thanks for creating this project, I'm really keen to get going with it!
Regards,
Jaume
Fixes #32