Add News "total cards viewed" P3A question #22222

DJAndries · 2022-04-11T19:51:13Z

Description

Add new News P3A question, for total cards viewed:

How many Brave News cards did you view in the past week?
Brave.Today.WeeklyTotalCardViews

None
1
2 to 10
11 to 20
21 to 40
41 to 80
81 to 100
101 or more

Miscellaneous Information:

Will raise PR soon.

The text was updated successfully, but these errors were encountered:

DJAndries · 2022-04-11T19:51:23Z

cc @mattmcalister

GeetaSarvadnya · 2022-05-06T07:05:21Z

Verification PASSED on


Brave | 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (64-bit)
-- | --
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1645)

and

Brave | 1.39.109 Chromium: 102.0.5005.50 (Official Build) (64-bit)
-- | --
Revision | f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS | Windows 10 Version 21H2 (Build 19044.1706)

Verified the description from the issue Add News "total cards viewed" P3A question #22222 (comment)
Logged Incorrect response value for the metrics Brave.Today.WeeklyMaxCardViewsCount when 1 card is viewed #22720
Logged Incorrect response value for the metrics Brave.Today.WeeklyMaxCardViewsCount when 9 cards are viewed #22721
Logged Incorrect response values for the metrics Brave.Today.WeeklyTotalCardViews in an upgraded profile #22934

Clean profile

Case 1: Brave.Today.WeeklyTotalCardViews =0_PASSED

Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 when brave today is not enabled or no cards are viewed

Case 2: Brave.Today.WeeklyTotalCardViews =1_PASSED

Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 1 when brave today is enabled and one card is viewed

Case 3: Brave.Today.WeeklyTotalCardViews =(2 to 10)_PASSED

Case 1: View 2 cards

Clean profile 1.39.x
Enable Brave news and view two cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 when brave today is enabled and two cards are viewed

Case 2:

Clean profile 1.39.x
Enable Brave news and view three cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 when brave today is enabled and three cards are viewed

Case 3:

Clean profile 1.39.x
Enable Brave news and view two cards
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 as expected (as still week has not elapsed hence the value is 2)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 4: View 10 cards

Clean profile 1.39.x
Enable Brave news and view 10 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 as expected

Case 4: Brave.Today.WeeklyTotalCardViews =(11 to 20)_PASSED

Case 1: View 11 cards

Clean profile 1.39.x
Enable Brave news and view 11 cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 when brave today is enabled and 11 cards are viewed

Case 2:

Clean profile 1.39.x
Enable Brave news and view 12 cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 when brave today is enabled and 12 cards are viewed

Case 3:

Clean profile 1.39.x
Enable Brave news and view 13 cards
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 as expected (as still week has not elapsed hence the value is 3)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 4: View 20 cards

Clean profile 1.39.x
Enable Brave news and view 10 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 as expected

Case 5: Brave.Today.WeeklyTotalCardViews =(21 to 40)_PASSED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 21 cards
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 4 as expected
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 4 as expected (as still week has not elapsed hence the value is 4)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 2: View 40 cards

Clean profile 1.39.x
Enable Brave news and view 40 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 4 as expected

Case 6: Brave.Today.WeeklyTotalCardViews =(41 to 80)_PASSED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 41 cards
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 5 as expected
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 5 as expected (as still week has not elapsed hence the value is 5)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 2: View 80 cards

Clean profile 1.39.x
Enable Brave news and view 80 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 5 as expected

Case 7: Brave.Today.WeeklyMaxCardViewsCount =(81 to 100)_PASSED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 81 cards
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 6 as expected (as still week has not elapsed hence the value is 6)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 2: View 100 cards

Clean profile 1.39.x
Enable Brave news and view 100 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 6 as expected

Case 8: Brave.Today.WeeklyMaxCardViewsCount =(100 or more)_PASSED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 100 cards
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 7 as expected
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 7 as expected (as still week has not elapsed hence the value is 6)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Upgrade profile

Case 1: Brave.Today.WeeklyTotalCardViews =0_PASSED

Instaall 1.38.x
Open brave://local-state file
Confirmed Brave.Today.WeeklyTotalCardViews metrics is NOT shown
Upgrade the profile to 1.39.x
Reload brave://local-state and confirmed Brave.Today.WeeklyTotalCardViews metrics response value is 0 when Brave news is NOT enabled
Enable brave news but don't view any cards
Reload brave://local-state and confirmed Brave.Today.WeeklyTotalCardViews metrics response value is 0 when no cards are viewed

Case 2: Brave.Today.WeeklyTotalCardViews =1_PASSED

Install 1.38.x and enable brave news
View one card
Upgrade the profile to 1.39.x
Wait until Brave news loads in opened NTP
Reload brave://local-state and confirmed that Brave.Today.WeeklyTotalCardViews metrics value is 2 instead of 1 which is expected as per Follow up of #21519 - Incorrect response value for WeeklyAddedDirectFeedsCount in an upgraded profile #22709 (comment)

Case 3: Brave.Today.WeeklyTotalCardViews =(2 to 10)_PASSED

Install 1.38.x and enable brave news
View 8 cards
Upgrade the profile to 1.39.x
Wait until Brave news loads in opened NTP
Reload brave://local-state and confirmed that Brave.Today.WeeklyTotalCardViews metrics value is 2 as expected

Case 4: Brave.Today.WeeklyTotalCardViews =(11 to 20)_PASSED

Install 1.38.x and enable brave news
View 11 cards
Upgrade the profile to 1.39.x
Wait until Brave news loads in opened NTP
Reload brave://local-state and confirmed that Brave.Today.WeeklyTotalCardViews metrics value is 2 instead of 3 which is expected as per Follow up of #21519 - Incorrect response value for WeeklyAddedDirectFeedsCount in an upgraded profile #22709 (comment)

Case 5: Brave.Today.WeeklyTotalCardViews =(21 to 40)_PASSED

Install 1.38.x and enable brave news
View 21 cards
Upgrade the profile to 1.39.x
Wait until Brave news loads in opened NTP
Reload brave://local-state and confirmed that Brave.Today.WeeklyTotalCardViews metrics value is 2 instead of 3 which is expected as per Follow up of #21519 - Incorrect response value for WeeklyAddedDirectFeedsCount in an upgraded profile #22709 (comment)

GeetaSarvadnya · 2022-05-06T07:29:16Z

@DJAndries There is no metrics called Brave.Today.WeeklyTotalCardViews looks like it's mapping with the metrics Brave.Today.WeeklyMaxCardViewsCount which is showing up in brave://local-state. Could you update the issue along with the P3A wiki if it's correct? Thanks!

GeetaSarvadnya · 2022-05-06T09:28:31Z

@DJAndries Logged the issues above. Could you take look at them and update the response values if required so that I can proceed further with issue verification. Thanks!

LaurenWags · 2022-05-09T12:53:50Z

Adding QA/Blocked until the above is resolved

DJAndries · 2022-05-17T18:55:36Z

@DJAndries There is no metrics called Brave.Today.WeeklyTotalCardViews looks like it's mapping with the metrics Brave.Today.WeeklyMaxCardViewsCount which is showing up in brave://local-state. Could you update the issue along with the P3A wiki if it's correct? Thanks!

WeeklyTotalCardViews is the correct metric name, however, I made a mistake by not using that metric name in the code. brave/brave-core#13360 will resolve this once merged. I will also request an uplift to 1.39.x.

kjozwiak · 2022-05-18T21:16:45Z

@GeetaSarvadnya brave/brave-core#13373 has been merged into 1.39.x so it should unblock #22222 (comment) once you get 1.39.109 or higher 👍

GeetaSarvadnya · 2022-05-20T15:11:56Z

Verification PASSED on Samsung Galaxy A52s version 11 running Bravearmx64.apk_1.39.109

Logged #22997

Clean profile

Case 1: Brave.Today.WeeklyTotalCardViews =0_PASSED

Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 when brave today is not enabled or no cards are viewed

Case 2: Brave.Today.WeeklyTotalCardViews =1_PASSED

Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 1 when brave today is enabled and one card is viewed

Case 3: Brave.Today.WeeklyTotalCardViews =(2 to 10)_FAILED

Case 1: View 2 cards

Clean profile 1.39.x
Enable Brave news and view two cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 when brave today is enabled and two cards are viewed

Case 2:

Clean profile 1.39.x
Enable Brave news and view three cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 when brave today is enabled and three cards are viewed

Case 3:

Clean profile 1.39.x
Enable Brave news and view two cards
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 as expected (as still week has not elapsed hence the value is 2)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 4: View 10 cards

Clean profile 1.39.x
Enable Brave news and view 10 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 2 as expected

Case 4: Brave.Today.WeeklyTotalCardViews =(11 to 20)_FAILED

Case 1: View 11 cards

Clean profile 1.39.x
Enable Brave news and view 11 cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 when brave today is enabled and 11 cards are viewed

Case 2:

Clean profile 1.39.x
Enable Brave news and view 12 cards
Open brave://local-state
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 when brave today is enabled and 12 cards are viewed

Case 3:

Clean profile 1.39.x
Enable Brave news and view 13 cards
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 as expected (as still week has not elapsed hence the value is 3)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 4: View 20 cards

Clean profile 1.39.x
Enable Brave news and view 10 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 3 as expected

Case 5: Brave.Today.WeeklyTotalCardViews =(21 to 40)_FAILED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 21 cards
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 4 as expected
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 4 as expected (as still week has not elapsed hence the value is 4)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 2: View 40 cards

Clean profile 1.39.x
Enable Brave news and view 40 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 4 as expected

Case 6: Brave.Today.WeeklyTotalCardViews =(41 to 80)_FAILED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 41 cards
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 5 as expected
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 5 as expected (as still week has not elapsed hence the value is 5)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 2: View 80 cards

Clean profile 1.39.x
Enable Brave news and view 80 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 5 as expected

Case 7: Brave.Today.WeeklyMaxCardViewsCount =(81 to 100)_FAILED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 81 cards
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 6 as expected (as still week has not elapsed hence the value is 6)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

Case 2: View 100 cards

Clean profile 1.39.x
Enable Brave news and view 100 cards
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 6 as expected

Case 8: Brave.Today.WeeklyMaxCardViewsCount =(100 or more)_FAILED

Case 1:

Clean profile 1.39.x
Enable Brave news and view 100 cards
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 7 as expected
Close the browser
Set the system date ahead by 7days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 7 as expected (as still week has not elapsed hence the value is 6)
Close the browser
Set the system date ahead by 7+1 days
Open brave://local-state file
Confirmed that the metrics Brave.Today.WeeklyTotalCardViews response value is 0 as expected (as the week has elapsed hence the value is 0)

DJAndries added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality features/P3A OS/Desktop labels Apr 11, 2022

DJAndries self-assigned this Apr 11, 2022

DJAndries mentioned this issue Apr 11, 2022

Add News weekly total card views P3A question brave/brave-core#12972

Merged

25 tasks

DJAndries added this to the 1.39.x - Nightly milestone Apr 14, 2022

DJAndries closed this as completed in brave/brave-core#12972 Apr 15, 2022

LaurenWags added the QA/Blocked label May 9, 2022

DJAndries mentioned this issue May 18, 2022

Fix weekly total card views histogram name in p3a metric name list (uplift to 1.39.x) brave/brave-core#13373

Merged

DJAndries removed the QA/Blocked label May 18, 2022

GeetaSarvadnya mentioned this issue May 19, 2022

Incorrect response values for the metrics Brave.Today.WeeklyTotalCardViews in an upgraded profile #22934

Closed

GeetaSarvadnya added the QA Pass-Win64 label May 19, 2022

GeetaSarvadnya added the QA Pass - Android ARM label May 23, 2022

GeetaSarvadnya mentioned this issue Jun 9, 2022

Follow up of #22222 - Incorrect response value for the metrics Brave.Today.WeeklyMaxCardViewsCount when various numbers of cards are viewed #22997

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add News "total cards viewed" P3A question #22222

Add News "total cards viewed" P3A question #22222

DJAndries commented Apr 11, 2022 •

edited

Loading

DJAndries commented Apr 11, 2022

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

LaurenWags commented May 9, 2022

DJAndries commented May 17, 2022

kjozwiak commented May 18, 2022

GeetaSarvadnya commented May 20, 2022 •

edited

Loading

Add News "total cards viewed" P3A question #22222

Add News "total cards viewed" P3A question #22222

Comments

DJAndries commented Apr 11, 2022 • edited Loading

Description

Miscellaneous Information:

DJAndries commented Apr 11, 2022

GeetaSarvadnya commented May 6, 2022 • edited Loading

GeetaSarvadnya commented May 6, 2022 • edited Loading

GeetaSarvadnya commented May 6, 2022 • edited Loading

LaurenWags commented May 9, 2022

DJAndries commented May 17, 2022

kjozwiak commented May 18, 2022

GeetaSarvadnya commented May 20, 2022 • edited Loading

DJAndries commented Apr 11, 2022 •

edited

Loading

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

GeetaSarvadnya commented May 6, 2022 •

edited

Loading

GeetaSarvadnya commented May 20, 2022 •

edited

Loading