Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to view ads after 426 Upgrade Required #23957

Closed
btlechowski opened this issue Jul 9, 2022 · 1 comment
Closed

Able to view ads after 426 Upgrade Required #23957

btlechowski opened this issue Jul 9, 2022 · 1 comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/ads OS/Desktop QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

Follow up to: #21388

User can view ads and be paid for them after 426.
After 426 from any end point we should stop serving ads

Steps to Reproduce

  1. Override https://mywallet.ads.brave.com/v2/confirmation/payment/* response code to 426
  2. Enable rewards and ads
  3. View an ad
  4. redeem the payment tokens -> will give 426
  5. View an ad

Actual result:

User can view and be paid for ads
The UI indicates that this is not possible:
image

Expected result:

User is not served nor paid for ads till browser is upgraded

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.41.94 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

cc @brave/qa-team @tmancey @codomii @rebron @Miyayes @aseren

@tmancey
Copy link
Contributor

tmancey commented Jul 11, 2022

Closing as resolved by #23958

@tmancey tmancey closed this as completed Jul 11, 2022
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jul 11, 2022
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/ads OS/Desktop QA/Test-Plan-Specified QA/Yes
Projects
Archived in project
Development

No branches or pull requests

2 participants