Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user if they need to update Brave in order for Ads to work #21388

Closed
2 tasks done
Miyayes opened this issue Mar 1, 2022 · 7 comments · Fixed by brave/brave-core#13377
Closed
2 tasks done

Notify user if they need to update Brave in order for Ads to work #21388

Miyayes opened this issue Mar 1, 2022 · 7 comments · Fixed by brave/brave-core#13377

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 1, 2022

Description

https://github.com/brave/internal/issues/856

UI designs:

image

  • Rewards panel notification
  • Rewards settings page (Ads component) notification

Ready to implement.

@zenparsing
Copy link

It might be worthwhile to think about adding support for "upgrade" status codes that could be returned for other rewards backend endpoints as well.

@Miyayes Miyayes added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Mar 3, 2022
@tmancey tmancey added design A design change, especially one which needs input from the design team and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Mar 16, 2022
@jsecretan jsecretan added 3_points For Agile sizing 5_points For Agile sizing and removed 3_points For Agile sizing labels Mar 16, 2022
@Miyayes Miyayes assigned tmancey and unassigned minkyeongshin Mar 21, 2022
@Miyayes Miyayes removed the design A design change, especially one which needs input from the design team label Mar 21, 2022
@aseren aseren assigned aseren and tmancey and unassigned tmancey and aseren Apr 8, 2022
@aseren aseren self-assigned this Apr 21, 2022
@tmancey tmancey removed their assignment May 10, 2022
@aseren
Copy link

aseren commented May 13, 2022

Per dm: also need to show message on NTP widget. Should base it off this design, and make background color red:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 24, 2022

Verification PASSED on


Brave | 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1766)

  • Verified the test plan from Implement needs browser update to see ads alerts. brave-core#13377
  • Confirmed that the Oops, Your browser cannot receive Brave Private Ads, your browser needs to be updated to continue seeing ads message is shown when ads requests return the response status code 426
  • Turned off the rewrite rules in Charles/closed Charles and confirmed the alert message is not hidden/removed
  • Confirmed that Alert message is not hidden until browser restarts
Charles settings Rewards settings page NTP widget
image (1) image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.41.80 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)
  • Verified the test plan from https://github.com/brave/brave-core/pull/13377
  • Confirmed that the Oops, Your browser cannot receive Brave Private Ads, your browser needs to be updated to continue seeing ads message is shown when ads requests return the response status code 426
  • Turned off the rewrite rules in Charles/closed Charles and confirmed the alert message is not hidden/removed
  • Confirmed that Alert message is not hidden until browser restarts
Charles Proxy Charles Proxy settings NTP widget Rewards page
Screen Shot 2022-06-27 at 1 30 52 PM Screen Shot 2022-06-27 at 1 12 41 PM Screen Shot 2022-06-27 at 1 33 01 PM Screen Shot 2022-06-27 at 1 33 08 PM

@btlechowski
Copy link

Verification passed on

Brave 1.41.94 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS
  • Verified the test plan from https://github.com/brave/brave-core/pull/13377
  • Confirmed that the Oops, Your browser cannot receive Brave Private Ads, your browser needs to be updated to continue seeing ads message is shown when ads requests return the response status code 426
  • Turned off the rewrite rules in Charles/closed Charles and confirmed the alert message is not hidden/removed
  • Confirmed that Alert message is not hidden until browser restarts

Unblinded tokens https://mywallet.ads.brave.com/v2/confirmation/token/*

Log:

[9258:9258:0709/105300.961745:VERBOSE1:refill_unblinded_tokens.cc(137)] OnRequestSignedTokens
[9258:9258:0709/105300.968614:VERBOSE6:refill_unblinded_tokens.cc(139)] URL Response:
  URL: https://mywallet.ads.brave.com/v2/confirmation/token/0a7c8cc1-0da6-4677-918d-e54a0bf7e7c7
  Response Status Code: 426
  Response: {"nonce":"bc3c9c86-67dc-4c08-8d1f-47dac9e45b81"}
[9258:9258:0709/105300.971619:VERBOSE1:refill_unblinded_tokens.cc(143)] Failed to request signed tokens as a browser upgrade is required

image
image

redeem payment tokens https://mywallet.ads.brave.com/v2/confirmation/payment/*

Log:

[11440:11440:0710/120029.259724:VERBOSE1:redeem_unblinded_payment_tokens.cc(117)] OnRedeemUnblindedPaymentTokens
[11440:11440:0710/120029.260971:VERBOSE6:redeem_unblinded_payment_tokens.cc(119)] URL Response:
  URL: https://mywallet.ads.brave.com/v2/confirmation/payment/2997b176-8a82-43ba-952c-bc521ecd66d9
  Response Status Code: 426
  Response: {"message":"Ok","status":200}
[11440:11440:0710/120029.262056:VERBOSE1:redeem_unblinded_payment_tokens.cc(125)] Failed to redeem unblinded payment token as a browser upgrade is required

image
image

catalog https://static.ads.brave.com/v9/catalog

Log:

[12304:12304:0709/122253.923138:VERBOSE1:catalog.cc(86)] OnCatalog
[12304:12304:0709/122253.980605:VERBOSE1:catalog.cc(98)] Failed to fetch catalog as a browser upgrade is required

image
image

issuers https://static.ads.brave.com/v1/issuers/

Log:

[13789:13789:0709/123033.186752:VERBOSE1:issuers.cc(86)] Failed to fetch issuers as a browser upgrade is required
[13789:13789:0709/123033.257714:INFO:account.cc(273)] Failed to fetch issuers

image
image

confirmation https://anonymous.ads.brave.com/v2/confirmation/*

Log:

[14505:14505:0709/123716.674030:VERBOSE1:redeem_unblinded_token.cc(162)] Failed to fetch payment token as a browser upgrade is required
[14505:14505:0709/123716.674515:VERBOSE1:confirmations.cc(323)] Failed to redeem unblinded token for ad_notification with confirmation id b79b2562-1a5e-4ecc-a6d8-6a2c016f4a80, transaction id ca85c64a-2393-4776-af71-0ab5b7e3593c, creative instance id c80153f6-cf22-41c0-8c2c-24c1f9a23c96 and view

image

retry failed confirmations due to 426:

The failed confirmations were not retried. failed_confirmations are empty in config.json
image

Logged #23958

serving ads after 426:

ads are served after 426 and user is paid for them
Tested on NTP SI

[11440:11440:0710/120303.766137:VERBOSE1:redeem_unblinded_payment_tokens.cc(125)] Failed to redeem unblinded payment token as a browser upgrade is required
[11440:11440:0710/120303.766660:VERBOSE1:account.cc(292)] Failed to redeem unblinded payment tokens
[11440:11440:0710/120326.206843:VERBOSE3:new_tab_page_ad_event_viewed.cc(23)] Viewed new tab page ad with placement id b6b8f3d4-ffd5-42e8-9418-035f281c31d0 and creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417
[11440:11440:0710/120326.274529:VERBOSE6:new_tab_page_ad_event_viewed.cc(31)] Successfully logged new tab page ad viewed event
[11440:11440:0710/120326.287558:VERBOSE3:new_tab_page_ad_event_served.cc(23)] Served new tab page ad with placement id b6b8f3d4-ffd5-42e8-9418-035f281c31d0 and creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417
[11440:11440:0710/120326.388014:VERBOSE2:tab_manager.cc(95)] Tab id 9 was updated
[11440:11440:0710/120326.425943:VERBOSE6:user_activity_manager.cc(48)] Triggered event: 11 (7.5:2:3600 s)
[11440:11440:0710/120326.429432:VERBOSE3:ads_impl.cc(804)] Successfully processed deposit for new_tab_page_ad with creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417 and view valued at 0.01
[11440:11440:0710/120326.463290:VERBOSE1:confirmations.cc(61)] Confirming view for new_tab_page_ad with transaction id aef7d54b-4370-45be-ae07-27a58cda476d and creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417
[11440:11440:0710/120326.624539:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[11440:11440:0710/120326.738012:VERBOSE1:redeem_unblinded_token.cc(71)] CreateConfirmation
[11440:11440:0710/120326.795255:VERBOSE2:redeem_unblinded_token.cc(72)] POST /v2/confirmation/{confirmation_id}/{credential}
[11440:11440:0710/120326.797202:VERBOSE6:redeem_unblinded_token.cc(76)] URL Request:
  URL: https://anonymous.ads.brave.com/v2/confirmation/f694d87f-967f-4c8f-a917-241fdc6024ab/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJoc1pQd0FvODdmU1FnOGhUVzBybDJuamJEMUNoM1VpRnVJL3hUemozbkJJPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY2F0YWxvZ1wiOlt7XCJpZFwiOlwiNWJjODI4YzUzMDY0ZmUwNWVlYTE4ZWUzODc2YTViNmI3NmJjNWQyM1wifV0sXCJjb3VudHJ5Q29kZVwiOlwiVVNcIixcImNyZWF0ZWRBdFRpbWVzdGFtcFwiOlwiMjAyMi0wNy0xMFQxMDowMDowMC4wMDBaXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjAxMjMxMjFmLThjNmUtNDY1MC1iMDgyLTA1YTljNWI5ZTQxN1wiLFwib2R5c3NleVwiOlwiaG9zdFwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJwdWJsaWNLZXlcIjpcIm9NeDhoVzZ3OHcvQVVHb0pNQU1icmRlVjFGb3FyUmtvUjNCVmErNWxERGs9XCIsXCJzdHVkaWVzXCI6W10sXCJzeXN0ZW1UaW1lc3RhbXBcIjpcIjIwMjItMDctMTBUMTA6MDA6MDAuMDAwWlwiLFwidHlwZVwiOlwidmlld1wiLFwidmVyc2lvbk51bWJlclwiOlwiMTAzLjAuNTA2MC4xMTRcIn0iLCJzaWduYXR1cmUiOiJTejVrbzE1VklkcHdoczhKTkVTcEtUc3V3eEdrZWhXZUNDMWZJVmhndzRreWRhUG5KZ2hYUVBBUGlVMWNIVHBiMmlveGxWU0tzNWxrZzRNdjdSdi9QUT09IiwidCI6ImhTY0lQdGt1dzVJK1I2MXF0Rzk5a0puZHh0TlpZdkl3MG9Gdlg5NnNyWW5WT1FueERTd2RLaVJzcnhicG5IRmozWjduaXhPeno1dGpMUm0wSzhmZ1F3PT0ifQ==
  Content: {"blindedPaymentTokens":["hsZPwAo87fSQg8hTW0rl2njbD1Ch3UiFuI/xTzj3nBI="],"buildChannel":"release","catalog":[{"id":"5bc828c53064fe05eea18ee3876a5b6b76bc5d23"}],"countryCode":"US","createdAtTimestamp":"2022-07-10T10:00:00.000Z","creativeInstanceId":"0123121f-8c6e-4650-b082-05a9c5b9e417","odyssey":"host","payload":{},"platform":"linux","publicKey":"oMx8hW6w8w/AUGoJMAMbrdeV1FoqrRkoR3BVa+5lDDk=","studies":[],"systemTimestamp":"2022-07-10T10:00:00.000Z","type":"view","versionNumber":"103.0.5060.114"}
  Content Type: application/json
  Method: kPost
[11440:11440:0710/120326.798928:VERBOSE6:new_tab_page_ad_event_served.cc(31)] Successfully logged new tab page ad served event
[11440:11440:0710/120327.141868:VERBOSE1:redeem_unblinded_token.cc(87)] OnCreateConfirmation
[11440:11440:0710/120327.147290:VERBOSE6:redeem_unblinded_token.cc(89)] URL Response:
  URL: https://anonymous.ads.brave.com/v2/confirmation/f694d87f-967f-4c8f-a917-241fdc6024ab/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJoc1pQd0FvODdmU1FnOGhUVzBybDJuamJEMUNoM1VpRnVJL3hUemozbkJJPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY2F0YWxvZ1wiOlt7XCJpZFwiOlwiNWJjODI4YzUzMDY0ZmUwNWVlYTE4ZWUzODc2YTViNmI3NmJjNWQyM1wifV0sXCJjb3VudHJ5Q29kZVwiOlwiVVNcIixcImNyZWF0ZWRBdFRpbWVzdGFtcFwiOlwiMjAyMi0wNy0xMFQxMDowMDowMC4wMDBaXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcIjAxMjMxMjFmLThjNmUtNDY1MC1iMDgyLTA1YTljNWI5ZTQxN1wiLFwib2R5c3NleVwiOlwiaG9zdFwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcImxpbnV4XCIsXCJwdWJsaWNLZXlcIjpcIm9NeDhoVzZ3OHcvQVVHb0pNQU1icmRlVjFGb3FyUmtvUjNCVmErNWxERGs9XCIsXCJzdHVkaWVzXCI6W10sXCJzeXN0ZW1UaW1lc3RhbXBcIjpcIjIwMjItMDctMTBUMTA6MDA6MDAuMDAwWlwiLFwidHlwZVwiOlwidmlld1wiLFwidmVyc2lvbk51bWJlclwiOlwiMTAzLjAuNTA2MC4xMTRcIn0iLCJzaWduYXR1cmUiOiJTejVrbzE1VklkcHdoczhKTkVTcEtUc3V3eEdrZWhXZUNDMWZJVmhndzRreWRhUG5KZ2hYUVBBUGlVMWNIVHBiMmlveGxWU0tzNWxrZzRNdjdSdi9QUT09IiwidCI6ImhTY0lQdGt1dzVJK1I2MXF0Rzk5a0puZHh0TlpZdkl3MG9Gdlg5NnNyWW5WT1FueERTd2RLaVJzcnhicG5IRmozWjduaXhPeno1dGpMUm0wSzhmZ1F3PT0ifQ==
  Response Status Code: 201
  Response: {"id":"f694d87f-967f-4c8f-a917-241fdc6024ab","payload":{},"createdAt":"2022-07-09T10:03:49.728Z","type":"view","modifiedAt":"2022-07-09T10:03:49.728Z","creativeInstanceId":"0123121f-8c6e-4650-b082-05a9c5b9e417"}
[11440:11440:0710/120327.153849:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[11440:11440:0710/120327.154139:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[11440:11440:0710/120327.154331:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://anonymous.ads.brave.com/v2/confirmation/f694d87f-967f-4c8f-a917-241fdc6024ab/paymentToken
  Method: kGet
[11440:11440:0710/120327.472013:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[11440:11440:0710/120327.472579:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://anonymous.ads.brave.com/v2/confirmation/f694d87f-967f-4c8f-a917-241fdc6024ab/paymentToken
  Response Status Code: 202
  Response: {"error":"Payment Tokens are not ready","statusCode":202}
[11440:11440:0710/120327.473028:VERBOSE1:redeem_unblinded_token.cc(157)] Payment token is not ready
[11440:11440:0710/120327.473598:VERBOSE1:confirmations.cc(323)] Failed to redeem unblinded token for new_tab_page_ad with confirmation id f694d87f-967f-4c8f-a917-241fdc6024ab, transaction id aef7d54b-4370-45be-ae07-27a58cda476d, creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417 and view
[11440:11440:0710/120327.475524:VERBOSE1:confirmations.cc(205)] Added view confirmation for new_tab_page_ad with id f694d87f-967f-4c8f-a917-241fdc6024ab, transaction idaef7d54b-4370-45be-ae07-27a58cda476d and creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417 to the confirmations queue
[11440:11440:0710/120327.511743:VERBOSE1:refill_unblinded_tokens.cc(92)] No need to refill unblinded tokens as we already have 46 unblinded tokens which is above the minimum threshold of 20
[11440:11440:0710/120327.532981:VERBOSE1:confirmations.cc(100)] Retry sending failed confirmations in 0 hours, 0 minutes, 2 seconds at 12:03:29.502
[11440:11440:0710/120327.805805:VERBOSE1:conversions.cc(223)] URL is not supported for conversions
[11440:11440:0710/120327.809899:VERBOSE1:ads_impl.cc(269)] chrome scheme is not supported for text content
[11440:11440:0710/120327.932848:VERBOSE1:uphold.cc(114)] Uphold wallet is not VERIFIED.
[11440:11440:0710/120329.506838:VERBOSE1:confirmations.cc(229)] Removed view confirmation for new_tab_page_ad with id f694d87f-967f-4c8f-a917-241fdc6024ab, transaction id aef7d54b-4370-45be-ae07-27a58cda476d and creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417 from the confirmations queue
[11440:11440:0710/120329.515211:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[11440:11440:0710/120329.535884:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[11440:11440:0710/120329.536292:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[11440:11440:0710/120329.536587:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://anonymous.ads.brave.com/v2/confirmation/f694d87f-967f-4c8f-a917-241fdc6024ab/paymentToken
  Method: kGet
[11440:11440:0710/120329.836690:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[11440:11440:0710/120329.837765:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://anonymous.ads.brave.com/v2/confirmation/f694d87f-967f-4c8f-a917-241fdc6024ab/paymentToken
  Response Status Code: 200
  Response: {"id":"f694d87f-967f-4c8f-a917-241fdc6024ab","createdAt":"2022-07-09T10:03:49.728Z","type":"view","modifiedAt":"2022-07-09T10:03:51.891Z","creativeInstanceId":"0123121f-8c6e-4650-b082-05a9c5b9e417","paymentToken":{"publicKey":"JlOezORiqLkFkvapoNRGWcMH3/g09/7M2UPEwMjRpFE=","batchProof":"Q5wRhqAdq2P1fcFh82W8tzvpk+aOJGHzAcdaOUKqVAwK3Dhkhc9gjl4GBIr0Bm0e0NggHTu0YX8uYt3nT6vtDw==","signedTokens":["cGtEqK+G5jubc7xK5RYZyE/0uWsOVrU1E+GoKhASCj4="]}}
[11440:11440:0710/120329.868586:VERBOSE1:confirmations.cc(303)] Successfully redeemed unblinded token for new_tab_page_ad with confirmation id f694d87f-967f-4c8f-a917-241fdc6024ab, transaction id aef7d54b-4370-45be-ae07-27a58cda476d, creative instance id 0123121f-8c6e-4650-b082-05a9c5b9e417 and view. You now have 4 unblinded payment tokens which will be redeemed in 0 hours, 0 minutes, 0 seconds at 02:46:59.775

Logged #23957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

10 participants