-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify user if they need to update Brave in order for Ads to work #21388
Closed
2 tasks done
Labels
5_points
For Agile sizing
enhancement
feature/rewards
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
Milestone
Comments
zenparsing
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Mar 2, 2022
It might be worthwhile to think about adding support for "upgrade" status codes that could be returned for other rewards backend endpoints as well. |
Miyayes
added
the
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
label
Mar 3, 2022
tmancey
added
design
A design change, especially one which needs input from the design team
and removed
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
labels
Mar 16, 2022
jsecretan
added
3_points
For Agile sizing
5_points
For Agile sizing
and removed
3_points
For Agile sizing
labels
Mar 16, 2022
Miyayes
removed
the
design
A design change, especially one which needs input from the design team
label
Mar 21, 2022
aseren
added a commit
to brave/brave-core
that referenced
this issue
May 19, 2022
aseren
added a commit
to brave/brave-core
that referenced
this issue
May 20, 2022
aseren
added a commit
to brave/brave-core
that referenced
this issue
May 20, 2022
aseren
added a commit
to brave/brave-core
that referenced
this issue
May 20, 2022
Verification PASSED on
|
Verified
|
Brave | 1.41.80 Chromium: 103.0.5060.53 (Official Build) beta (x86_64) |
---|---|
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853} |
OS | macOS Version 11.6.7 (Build 20G630) |
- Verified the test plan from
https://github.com/brave/brave-core/pull/13377
- Confirmed that the
Oops, Your browser cannot receive Brave Private Ads, your browser needs to be updated to continue seeing ads
message is shown when ads requests return the response status code426
- Turned off the rewrite rules in Charles/closed Charles and confirmed the alert message is not hidden/removed
- Confirmed that Alert message is not hidden until browser restarts
Charles Proxy | Charles Proxy settings | NTP widget | Rewards page |
---|---|---|---|
This was referenced Jul 9, 2022
Verification passed on
Unblinded tokens https://mywallet.ads.brave.com/v2/confirmation/token/*Log:
redeem payment tokens https://mywallet.ads.brave.com/v2/confirmation/payment/*Log:
catalog https://static.ads.brave.com/v9/catalogLog:
issuers https://static.ads.brave.com/v1/issuers/Log:
confirmation https://anonymous.ads.brave.com/v2/confirmation/*Log:
retry failed confirmations due to 426:The failed confirmations were not retried. Logged #23958 serving ads after 426:ads are served after 426 and user is paid for them
Logged #23957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5_points
For Agile sizing
enhancement
feature/rewards
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
Description
https://github.com/brave/internal/issues/856
UI designs:
Ready to implement.
The text was updated successfully, but these errors were encountered: